What the developer wrote
Authored by Peter D. Gray
cleanup
What changed, and why it matters
This commit only changes a test file. It reorders some assertions, adds blank lines for readability, and updates a comment from 'skip words' to 'skip quiz'. There is no change to the actual COLDCARD firmware code that users run, and nothing that affects security.
No action required. This is a non-security test cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff is confined to testing/test_ephemeral.py. It is purely cosmetic/test-maintenance: assertion order is swapped (m[0] checked before m[1]), whitespace is added, and an inline comment is corrected. No firmware logic, cryptography, UI flow, or trust boundary is modified.
Changed components
testing/test_ephemeral.pyInspect captured patch +8 / −2
diff --git a/testing/test_ephemeral.py b/testing/test_ephemeral.py
index 8384494..db9764b 100644
--- a/testing/test_ephemeral.py
+++ b/testing/test_ephemeral.py
@@ -1541,26 +1541,30 @@ def test_home_menu_xfp(goto_home, pick_menu_item, press_select, cap_story, cap_m
pick_menu_item("Always Show")
time.sleep(.3)
m = cap_menu()
- assert m[1] == "Ready To Sign"
assert m[0] == "<" + xfp2str(settings_get("xfp")) + ">"
+ assert m[1] == "Ready To Sign"
+
goto_eph_seed_menu()
pick_menu_item("Generate Words")
pick_menu_item(f"12 Words")
time.sleep(0.1)
- need_keypress("6") # skip words
+ need_keypress("6") # skip quiz
press_select()
+
time.sleep(.1)
_, story = cap_story()
if "Press (1) to store temporary seed" in story:
# seed vault enabled
press_select() # do not save
press_select() # new tmp seed
+
time.sleep(.2)
m = cap_menu()
assert m[1] == "Ready To Sign"
assert m[0] == "[" + xfp2str(settings_get("xfp")) + "]"
pick_menu_item("Restore Master")
press_select()
+
time.sleep(.3)
m = cap_menu()
assert m[1] == "Ready To Sign"
@@ -1568,11 +1572,13 @@ def test_home_menu_xfp(goto_home, pick_menu_item, press_select, cap_story, cap_m
# disable now
pick_menu_item("Settings")
pick_menu_item("Home Menu XFP")
+
time.sleep(.1)
_, story = cap_story()
if "Forces display of XFP" in story:
press_select()
pick_menu_item("Only Tmp")
+
time.sleep(.3)
m = cap_menu()
assert m[0] == "Ready To Sign"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.