What the developer wrote
Authored by scgbckbone
fix HSM UX message text
What changed, and why it matters
This commit fixes a typo in a user-facing message shown by the COLDCARD's HSM (Hardware Security Module) policy screen. The phrase 'Address values values will be shared' is corrected to 'Address values will be shared'. There is no security impact.
No security action needed; this is a cosmetic text fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change is a single-word duplicate removal in a UX string within shared/hsm.py and the corresponding test expectations in testing/test_hsm.py. It affects only displayed text and does not alter any logic, access control, cryptographic operation, or data flow.
Changed components
shared/hsm.pytesting/test_hsm.pyInspect captured patch +5 / −5
diff --git a/shared/hsm.py b/shared/hsm.py
index b786602..937975f 100644
--- a/shared/hsm.py
+++ b/shared/hsm.py
@@ -606,7 +606,7 @@ class HSMPolicy:
fd.write('- XPUB values will be shared, if path matches: m OR %s.\n'
% plist(self.share_xpubs))
if self.share_addrs:
- fd.write('- Address values values will be shared, if path matches: %s.\n'
+ fd.write('- Address values will be shared, if path matches: %s.\n'
% plist(self.share_addrs))
if self.priv_over_ux:
fd.write('- Status responses optimized for privacy.\n')
diff --git a/testing/test_hsm.py b/testing/test_hsm.py
index 0f2d359..35c5bff 100644
--- a/testing/test_hsm.py
+++ b/testing/test_hsm.py
@@ -170,10 +170,10 @@ def hsm_reset(dev, sim_exec):
(DICT(msg_paths=["any"]), "(any path)"),
# data sharing
- (DICT(share_addrs=["m/1'/2p/3H"]), ['Address values values will be shared', "m/1h/2h/3h"]),
- (DICT(share_addrs=["m/1", "m/2"]), ['Address values values will be shared', "m/1 OR m/2"]),
- (DICT(share_addrs=["any"]), ['Address values values will be shared', "(any path)"]),
- (DICT(share_addrs=["p2sh", "any"]), ['Address values values will be shared', "(any P2SH)", "(any path"]),
+ (DICT(share_addrs=["m/1'/2p/3H"]), ['Address values will be shared', "m/1h/2h/3h"]),
+ (DICT(share_addrs=["m/1", "m/2"]), ['Address values will be shared', "m/1 OR m/2"]),
+ (DICT(share_addrs=["any"]), ['Address values will be shared', "(any path)"]),
+ (DICT(share_addrs=["p2sh", "any"]), ['Address values will be shared', "(any P2SH)", "(any path"]),
(DICT(share_xpubs=["m/1'/2p/3H"]), ['XPUB values will be shared', "m/1h/2h/3h"]),
(DICT(share_xpubs=["m/1", "m/2"]), ['XPUB values will be shared', "m/1 OR m/2"]),
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.