Add changelog entry for msgsign JSON crash fix
What the developer wrote
Authored by copilot-swe-agent[bot]
Add changelog entry for msgsign JSON crash fix
Co-authored-by: Amiga500 <16525337+Amiga500@users.noreply.github.com>
What changed, and why it matters
This commit only adds a changelog note saying a previous fix stopped the COLDCARD hardware wallet from crashing when a message-signing request was valid JSON but not a JSON object (for example, a number or string instead of a dictionary). The actual code fix is not shown here, so we can only judge the issue from the changelog description. It appears to be a denial-of-service-style crash affecting message signing over NFC, QR, or SD card JSON files.
Locate and review the actual code fix that this changelog entry references; verify that the message-signing parser now validates that the top-level JSON value is an object before accessing object fields. Consider fuzzing NFC/QR/SD JSON inputs with arrays, primitives, and null values to confirm the crash is resolved and does not expose further parsing bugs.
Security signals we found
Device crash on malformed message-signing input
Input vector includes NFC, QR, and SD card JSON files
Valid JSON but wrong type (non-object) bypasses simple format checks
Changelog credits external contributor Amiga500
Evidence from the diff
The commit is a documentation-only addition to releases/Next-ChangeLog.md. It describes a bugfix for a device crash triggered when message-signing input parses as valid JSON but is not a JSON object. The affected input vectors are NFC, QR, and SD .json files. Because the patch itself does not contain the code change, classification relies entirely on the changelog description. The crash is likely an unhandled type assumption in the message-signing flow, possibly leading to a denial-of-service (device reboot/exception) rather than code execution or key extraction.
Changed components
COLDCARD firmware message-signing featureNFC message-signing input handlingQR message-signing input handlingSD card .json message-signing input handlingInspect captured patch +3 / −0
### releases/Next-ChangeLog.md
@@ -7,6 +7,9 @@ your addition and anything else already in this file.**
# Shared Improvements - Both Mk and Q
+- Bugfix: Fix device crash when message-signing input is valid JSON but not an
+ object (NFC / QR / SD `.json` file). Thanks to [@Amiga500](https://github.com/Amiga500).
+
- tbd
Why this scored 49/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.