AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 64 Monero

fix: open external links outside the app so the PIN lock can show (#3737)

Public commit record

What the developer wrote

Authored by Seth For Privacy

93/100 · Strong
fix: open external links outside the app so the PIN lock can show (#3737)

Links opened with the default launch mode use SFSafariViewController on
iOS. While it covers Flutter no lifecycle events reach Dart, so returning
from the background showed the browser without asking for the PIN.

Refs GHSA-329m-5v92-587r, CW-1707

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This update changes how the app opens web links so they launch in the device's regular browser instead of an embedded browser sheet. The problem was that on iOS the embedded sheet (SFSafariViewController) hid the app from normal background/foreground events, so when a user returned from viewing a link the wallet reappeared without asking for the PIN. That could let someone with brief physical access to an unlocked phone browse back to the wallet without re-entering the PIN. The patch forces links to open externally, restoring the normal app lifecycle and letting the PIN lock screen appear.

Recommended action

Verify that all remaining launchUrl/launchUrlString calls in the codebase use externalApplication or another mode that preserves lifecycle events, and confirm the PIN lock triggers reliably after returning from any browser on both iOS and Android. Consider adding a regression test for lifecycle transitions during external browsing.

Security signals we found

01

PIN/biometric lock bypass on iOS when returning from in-app browser

02

Use of SFSafariViewController default launch mode suppressing Flutter lifecycle events

03

Physical-access attack vector on an already-unlocked device

04

Patch applies a uniform remediation pattern across multiple link-opening call sites

Risk score

Why this scored 64/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 10/15
Affected reach 12/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.