AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 24 Monero

CW-1400-add-zcash-support-to-ledger (#3699)

Public commit record

What the developer wrote

Authored by Konstantin Ullrich

76/100 · Adequate
CW-1400-add-zcash-support-to-ledger (#3699)

* feat: add restore Zcash Ledger hardware wallet support

* fix: ZcashHeight.getTimeByBlockHeight with the correctly timestamped checkpoints

* feat: add Ledger Zcash sending support

* feat: refactor zcash autoshield

* feat: add UI for manual shielding support

* refactor: replace Theme-based text styles with explicit TextStyle in Zcash manual shield modal

* feat: Added a reusable `ensureDeviceConnection` method to streamline hardware wallet connection checks across various components. Updated shielding, swapping, and integration flows to utilize this helper, reducing code duplication and improving maintainability.

* fix: resolve parameter formatting in `unconfirmed_balance_widget` and correct conditional usage in `_minSweepThreshold`

* fix: update parameter formatting in `getBirthHeight` and track the last auto-shield timestamp

* fix: pass walletType to `HardwareWalletAccountOptionsPage` and update zkool dependency to latest commit

* fix: only show hardware wallet compatible zcash address types

* fix: track last auto-shield timestamp and adjust sweepable balance display

* Update cw_zcash/lib/src/zcash_wallet.dart

Co-authored-by: Omar Hatem <omarh.ismail1@gmail.com>

* Update cw_zcash/lib/src/zcash_wallet.dart

Co-authored-by: Omar Hatem <omarh.ismail1@gmail.com>

* refactor: extend ZcashLedgerException from CakeException for consistent error handling

---------

Co-authored-by: Omar Hatem <omarh.ismail1@gmail.com>
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit adds Zcash support for Ledger hardware wallets in Cake Wallet. It lets users restore a Zcash wallet from a Ledger, sign Zcash sends and shielding transactions on the device, and adds a manual shielding UI because hardware wallets cannot auto-shield. It also refreshes checkpoint timestamps and dependency versions. There is no direct evidence of a security vulnerability in the diff, but it is a large feature change touching sensitive code paths (transaction signing, hardware wallet connection, balance display), so it warrants careful review.

Recommended action

Treat this as a high-touch security review item. Verify that the Ledger signing flow never exposes private keys, that the signedTxPackage path cannot be replaced or replayed, that ensureDeviceConnection cannot be bypassed, and that the updated checkpoint data and dependency versions are trustworthy. Run integration tests for Zcash Ledger restore, send, and shield on both mainnet and testnet.

Security signals we found

01

New hardware wallet signing path for Zcash using Ledger APDU exchange

02

Minimum Ledger app version enforcement for Ironwood/v6 signing

03

Manual shielding UI added because auto-shield is disabled for hardware wallets

04

Reusable ensureDeviceConnection helper centralizes hardware wallet connection checks

05

Large dependency bump for zkool and ledger-flutter-plus

06

Checkpoint timestamp data regenerated from external API (Blockchair)

07

Balance display logic changed to hide sweepable balance shortly after auto-shield

Risk score

Why this scored 24/100

Our methodology →
Potential impact 4/30
Exploitability 3/25
Stealth signal 3/15
Affected reach 5/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.