← Watch feed
fix padding on NewWalletTypePage (#3333)
Public commit record
53/100 · Thin
What the developer wrote
Authored by malik1004x
fix padding on NewWalletTypePage (#3333)
✓ Descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
What changed, and why it matters
This commit is a routine user-interface layout fix. It changes how the wallet-type list scrolls and adjusts padding on the 'New Wallet Type' screen so the page displays correctly. There is no security-relevant change.
Recommended action
No security action needed; treat as a normal UI fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff replaces a Flexible+Padding+ListView with an Expanded+SingleChildScrollView wrapping the same Padding+ListView, and adds physics: NeverScrollableScrollPhysics and padding: EdgeInsets.zero to the inner ListView. This is a Flutter UI layout/padding adjustment only; no logic, input handling, cryptography, networking, or permissions are modified.
Changed components
lib/src/screens/new_wallet/new_wallet_type_page.dartInspect captured patch +63 / −59
diff --git a/lib/src/screens/new_wallet/new_wallet_type_page.dart b/lib/src/screens/new_wallet/new_wallet_type_page.dart
index 55bd1680..2c44370e 100644
--- a/lib/src/screens/new_wallet/new_wallet_type_page.dart
+++ b/lib/src/screens/new_wallet/new_wallet_type_page.dart
@@ -135,69 +135,73 @@ class WalletTypeFormState extends State<WalletTypeForm> {
fontSize: 14,
),
),
- Flexible(
- child: Padding(
- padding: const EdgeInsets.only(left: 18, right: 18, bottom: 12),
- child: Container(
- decoration: BoxDecoration(
- color: Theme.of(context).colorScheme.surfaceContainer,
- borderRadius: BorderRadius.circular(18),
- ),
- child: ListView.separated(
- key: const ValueKey('new_wallet_type_scrollable_key'),
- itemCount: filteredTypes.length,
- shrinkWrap: true,
- itemBuilder: (context, index) {
- final item = filteredTypes[index];
-
- return GestureDetector(
- key: ValueKey('new_wallet_type_${item.name}_button_key'),
- behavior: HitTestBehavior.opaque,
- onTap: () {
- onTypeSelected(item);
- },
- child: SizedBox(
- height: 48,
- child: Padding(
- padding: const EdgeInsets.symmetric(horizontal: 12.0),
- child: Row(
- mainAxisAlignment: MainAxisAlignment.spaceBetween,
- children: [
- Row(
- children: [
- CakeImageWidget(
- height: 24,
- width: 24,
- imageUrl: getCryptoCurrencyIconForWalletListItem(item),
- ),
- const SizedBox(width: 12),
- Text(walletTypeToDisplayName(item)),
- const SizedBox(width: 4),
- Text(
- walletTypeToDisplayTicker(item),
- style: TextStyle(
- color: Theme.of(context).colorScheme.onSurfaceVariant,
+ Expanded(
+ child: SingleChildScrollView(
+ child: Padding(
+ padding: const EdgeInsets.only(left: 18, right: 18, bottom: 12),
+ child: Container(
+ decoration: BoxDecoration(
+ color: Theme.of(context).colorScheme.surfaceContainer,
+ borderRadius: BorderRadius.circular(18),
+ ),
+ child: ListView.separated(
+ key: const ValueKey('new_wallet_type_scrollable_key'),
+ itemCount: filteredTypes.length,
+ shrinkWrap: true,
+ physics: NeverScrollableScrollPhysics(),
+ padding: EdgeInsets.zero,
+ itemBuilder: (context, index) {
+ final item = filteredTypes[index];
+
+ return GestureDetector(
+ key: ValueKey('new_wallet_type_${item.name}_button_key'),
+ behavior: HitTestBehavior.opaque,
+ onTap: () {
+ onTypeSelected(item);
+ },
+ child: SizedBox(
+ height: 48,
+ child: Padding(
+ padding: const EdgeInsets.symmetric(horizontal: 12.0),
+ child: Row(
+ mainAxisAlignment: MainAxisAlignment.spaceBetween,
+ children: [
+ Row(
+ children: [
+ CakeImageWidget(
+ height: 24,
+ width: 24,
+ imageUrl: getCryptoCurrencyIconForWalletListItem(item),
),
- )
- ],
- ),
- CakeImageWidget(
- imageUrl: "assets/new-ui/arrow_forward.svg",
- height: 16,
- colorFilter: ColorFilter.mode(
- Theme.of(context).colorScheme.onSurfaceVariant,
- BlendMode.srcIn,
+ const SizedBox(width: 12),
+ Text(walletTypeToDisplayName(item)),
+ const SizedBox(width: 4),
+ Text(
+ walletTypeToDisplayTicker(item),
+ style: TextStyle(
+ color: Theme.of(context).colorScheme.onSurfaceVariant,
+ ),
+ )
+ ],
),
- )
- ],
+ CakeImageWidget(
+ imageUrl: "assets/new-ui/arrow_forward.svg",
+ height: 16,
+ colorFilter: ColorFilter.mode(
+ Theme.of(context).colorScheme.onSurfaceVariant,
+ BlendMode.srcIn,
+ ),
+ )
+ ],
+ ),
),
),
- ),
- );
- },
- separatorBuilder: (context, index) => Container(
- height: 1,
- color: Theme.of(context).colorScheme.surfaceContainerHigh,
+ );
+ },
+ separatorBuilder: (context, index) => Container(
+ height: 1,
+ color: Theme.of(context).colorScheme.surfaceContainerHigh,
+ ),
),
),
),
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.