What the developer wrote
Authored by Robert Malikowski
fix swap filter checkbox
What changed, and why it matters
This is a one-line UI bug fix in a Flutter/Dart mobile wallet app. The change corrects which boolean value is checked when deciding what subtitle text and color to show for a swap-history filter checkbox. Previously it used the checkbox's own value; now it uses the app's trade-filter store state. There is no security relevance visible in the commit.
No security action needed. Treat as a normal UI fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In lib/new-ui/widgets/coins_page/assets_history/history_filters_page.dart, the subtitle rendering logic for a SwapFilterItem was changed from checking item.value() to checking dashboardViewModel.tradeFilterStore.displayAllTrades. This aligns the displayed label/color with the global filter state rather than the local checkbox value. The change is purely presentational and has no evident security implications.
Changed components
lib/new-ui/widgets/coins_page/assets_history/history_filters_page.dartInspect captured patch +1 / −1
diff --git a/lib/new-ui/widgets/coins_page/assets_history/history_filters_page.dart b/lib/new-ui/widgets/coins_page/assets_history/history_filters_page.dart
index 3a71a86c..072f1101 100644
--- a/lib/new-ui/widgets/coins_page/assets_history/history_filters_page.dart
+++ b/lib/new-ui/widgets/coins_page/assets_history/history_filters_page.dart
@@ -52,7 +52,7 @@ class HistoryFiltersPage extends StatelessWidget {
if (item is SwapFilterItem) {
final String subtitle;
final Color subtitleColor;
- if (item.value()) {
+ if (dashboardViewModel.tradeFilterStore.displayAllTrades) {
subtitle = S.of(context).manage_providers;
subtitleColor = Theme.of(context).colorScheme.onSurfaceVariant;
} else if (dashboardViewModel.tradeFilterStore.enabledProviders == 0) {
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.