What the developer wrote
Authored by tuxsudo
Minor UI Fixes (#3108)
* Fix Filter button padding
* Fix sign/verify closing popup
What changed, and why it matters
This commit contains two small user-interface fixes: it adjusts the spacing inside a filter button and fixes a bug where an error popup on the sign/verify screen might not close correctly. There is no indication these changes address a security problem.
No security action needed; treat as a routine UI bug fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff changes spacing from 0 to 6 in a Flutter Row widget for visual padding, and in sign_page.dart it renames the popup builder parameter from _ to _context and uses that context to check Navigator.canPop and call Navigator.of(_context).pop(). This resolves a likely closure/context bug where the wrong BuildContext was being used to dismiss the dialog. No security-relevant code paths are modified.
Changed components
lib/new-ui/widgets/coins_page/assets_history/assets_top_bar.dartlib/src/screens/dashboard/sign_page.dartInspect captured patch +3 / −3
diff --git a/lib/new-ui/widgets/coins_page/assets_history/assets_top_bar.dart b/lib/new-ui/widgets/coins_page/assets_history/assets_top_bar.dart
index 374319be..9ea80989 100644
--- a/lib/new-ui/widgets/coins_page/assets_history/assets_top_bar.dart
+++ b/lib/new-ui/widgets/coins_page/assets_history/assets_top_bar.dart
@@ -67,7 +67,7 @@ class AssetsTopBar extends StatelessWidget {
child: Padding(
padding: const EdgeInsets.symmetric(horizontal: 12.0),
child: Row(
- spacing: 0,
+ spacing: 6,
children: [
CakeImageWidget(
imageUrl: "assets/new-ui/options_slider.svg",
diff --git a/lib/src/screens/dashboard/sign_page.dart b/lib/src/screens/dashboard/sign_page.dart
index b04d3e91..293cb49d 100644
--- a/lib/src/screens/dashboard/sign_page.dart
+++ b/lib/src/screens/dashboard/sign_page.dart
@@ -144,13 +144,13 @@ class _SignPageState extends State<SignPage> {
WidgetsBinding.instance.addPostFrameCallback((_) {
showPopUp<void>(
context: context,
- builder: (_) {
+ builder: (_context) {
return AlertWithOneAction(
alertTitle: S.current.error,
alertContent: state.error,
buttonText: S.of(context).ok,
buttonAction: () {
- if (context.mounted && Navigator.canPop(context)) Navigator.of(context).pop();
+ if (context.mounted && Navigator.canPop(_context)) Navigator.of(_context).pop();
},
);
});
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.