fix sizing (#3298)

Cake Wallet/Cake Wallet / Monero.com

8c1c700b View source ↗

Public commit record

What the developer wrote

Authored by malik1004x

36/100 · Opaque

fix sizing (#3298)

✓ Subject identifies a change✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body

The short version

What changed, and why it matters

This commit is a routine user-interface layout fix. It wraps a currency picker in a SafeArea so content isn't hidden by device notches or system bars, removes an extra 24-pixel gap below search boxes, and sets the QR code display to 70% of screen width instead of letting it size automatically. There is no security-relevant change.

Recommended action

No security action needed; treat as a normal UI polish commit.

Security signals we found

No strong security signals were identified.

Technical analysis

Evidence from the diff

The diff adjusts Flutter UI sizing only: (1) CurrencyPickerSheet is wrapped in SafeArea(top: false) to respect bottom/system insets; (2) a const SizedBox(height: 24) spacer is removed from both multi- and single-network currency picker search headers; (3) URQR’s QrImage size changes from null (auto) to MediaQuery.of(context).size.width * 0.7. No logic, validation, cryptography, networking, permissions, or data-handling code is modified.

Changed components

lib/new-ui/widgets/currency_picker/currency_picker_sheet.dartlib/new-ui/widgets/currency_picker/multi_network_currency_picker.dartlib/new-ui/widgets/currency_picker/single_network_currency_picker.dartlib/src/screens/ur/widgets/urqr.dart

Inspect captured patch +18 / −17

diff --git a/lib/new-ui/widgets/currency_picker/currency_picker_sheet.dart b/lib/new-ui/widgets/currency_picker/currency_picker_sheet.dart
index 185d7a20..be6600d5 100644
--- a/lib/new-ui/widgets/currency_picker/currency_picker_sheet.dart
+++ b/lib/new-ui/widgets/currency_picker/currency_picker_sheet.dart
@@ -35,20 +35,23 @@ class CurrencyPickerSheet extends StatelessWidget {
           borderRadius: const BorderRadius.vertical(top: Radius.circular(24)),
           color: colors.surface,
         ),
-        child: Column(
-          mainAxisSize: MainAxisSize.max,
-          children: [
-            ModalTopBar(
-              title: S.of(context).select_asset,
-              leadingIcon: const Icon(Icons.close),
-              onLeadingPressed: () => Navigator.of(context).maybePop(),
-            ),
-            Expanded(
-              child: args.isPreFiltered
-                  ? SingleNetworkCurrencyPicker(args: args)
-                  : MultiNetworkCurrencyPicker(args: args),
-            ),
-          ],
+        child: SafeArea(
+          top: false,
+          child: Column(
+            mainAxisSize: MainAxisSize.max,
+            children: [
+              ModalTopBar(
+                title: S.of(context).select_asset,
+                leadingIcon: const Icon(Icons.close),
+                onLeadingPressed: () => Navigator.of(context).maybePop(),
+              ),
+              Expanded(
+                child: args.isPreFiltered
+                    ? SingleNetworkCurrencyPicker(args: args)
+                    : MultiNetworkCurrencyPicker(args: args),
+              ),
+            ],
+          ),
         ),
       ),
     );
diff --git a/lib/new-ui/widgets/currency_picker/multi_network_currency_picker.dart b/lib/new-ui/widgets/currency_picker/multi_network_currency_picker.dart
index fad7475d..9b31b8a3 100644
--- a/lib/new-ui/widgets/currency_picker/multi_network_currency_picker.dart
+++ b/lib/new-ui/widgets/currency_picker/multi_network_currency_picker.dart
@@ -174,7 +174,6 @@ class _MultiNetworkCurrencyPickerState extends State<MultiNetworkCurrencyPicker>
           controller: _searchController,
           hintText: S.of(context).search,
         ),
-        const SizedBox(height: 24),
       ],
     );
   }
diff --git a/lib/new-ui/widgets/currency_picker/single_network_currency_picker.dart b/lib/new-ui/widgets/currency_picker/single_network_currency_picker.dart
index d2bedf81..79bb9962 100644
--- a/lib/new-ui/widgets/currency_picker/single_network_currency_picker.dart
+++ b/lib/new-ui/widgets/currency_picker/single_network_currency_picker.dart
@@ -120,7 +120,6 @@ class _SingleNetworkCurrencyPickerState extends State<SingleNetworkCurrencyPicke
           controller: _searchController,
           hintText: S.of(context).search,
         ),
-        const SizedBox(height: 24),
       ],
     );
   }
diff --git a/lib/src/screens/ur/widgets/urqr.dart b/lib/src/screens/ur/widgets/urqr.dart
index 7649933d..c12b7c9e 100644
--- a/lib/src/screens/ur/widgets/urqr.dart
+++ b/lib/src/screens/ur/widgets/urqr.dart
@@ -79,7 +79,7 @@ class _URQRState extends State<URQR> {
               child: QrImage(
                 data: frames[frame % frames.length],
                 version: -1,
-                size: null,
+                size: MediaQuery.of(context).size.width * 0.7,
               ),
             ),
           ),

Risk score

Why this scored 15/100

Our methodology →

Potential impact 0/30

Exploitability 0/25

Stealth signal 0/15

Affected reach 0/15

Confidence 10/10

Evidence quality 5/5

Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

What the developer wrote

What changed, and why it matters

Security signals we found

Evidence from the diff

Changed components

Why this scored 15/100

Community notes

Related watches

fix: add new images and fix integration tests (#3679)

Add Robinhood Chain (#3398)

chore: migrate to hosted scalable CI (#3620)