AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 37 Monero

LCW-1144 cupcake litecoin (#2557)

Public commit record

What the developer wrote

Authored by cyan

76/100 · Adequate
LCW-1144 cupcake litecoin (#2557)

* Add psbt rpcs

* Only build arm64

* Rebuild protos

* Update proto

* Add psbt create rpc

* Restore wallet stuff

* more stuff

* more stuff

* more stuff

* Fix open wallet

* Fix mweb enabled

* Start of buildPsbt

* Update proto

* Psbt add recipients

* fixes

* slightly better

* more fixes

* decode ur

* add more commit code

* Update proto

* use new proto

* Don't eat psbt rpc errors

* Use unix domain socket for mwebd

* add gitignore

* Undo build only arm64

* fix pure mweb txns

* fix mweb txids

* fix ci

* fix blank pegin address

* chore: update cw_mweb dependencies
chore: remove cw_core as dependency from cw_mweb

* fix: Ltub restore

* fix: address review crashes, fix non-mweb view only wallets

* minor fixes

---------

Co-authored-by: Hector Chu <hectorchu@gmail.com>
Co-authored-by: OmarHatem <omarh.ismail1@gmail.com>
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit adds new Litecoin MWEB (privacy feature) wallet capabilities to Cake Wallet, including restoring wallets from extended public keys and handling special PSBT (partially signed Bitcoin-like) transactions. It also upgrades several Go dependencies and switches the local MWEB service from a network port to a Unix domain socket. There is no clear security bug, but the changes touch sensitive wallet code and key handling, so they deserve careful review.

Recommended action

Treat this as a high-sensitivity feature change requiring focused review: verify that scanSecret/spendPubkey are encrypted at rest via WalletKeysData, confirm the Unix socket has restrictive filesystem permissions and is not accessible to other apps, audit PSBT/UR parsing for malicious input, and review the mwebd dependency changelog for security fixes in the bumped versions. The unimplemented hog-ex detection TODO should be tracked and completed before relying on the confirmation check.

Security signals we found

01

New restore path accepts xpub + scanSecret + spendPubkey and stores them in WalletKeysData JSON

02

MWEB scan/spend secrets are passed as byte arrays over local gRPC to mwebd

03

Switch from TCP loopback to Unix domain socket for mwebd reduces localhost exposure

04

Go dependency bumps include crypto/net/sys/grpc/protobuf; no CVE mapping supplied

05

PSBT construction and QR/UR decoding paths added for hardware-wallet-style signing

06

Error handling added around scriptHash computation and server startup

07

TODO comment indicates hog-ex input detection is not yet implemented

Risk score

Why this scored 37/100

Our methodology →
Potential impact 8/30
Exploitability 7/25
Stealth signal 6/15
Affected reach 7/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.