AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 18 Monero

Charts: fix 'Cannot compare money in different currencies' crash (#3713)

Public commit record

What the developer wrote

Authored by claude[bot]

81/100 · Strong
Charts: fix 'Cannot compare money in different currencies' crash (#3713)

* Charts: load prices with the currency the cache round-trips to

PriceData rows are cached by CryptoCurrency.apiString ("crypto.$title",
no tag), so cached rows for e.g. usdterc20 come back as generic usdt
while fresh API rows keep usdterc20. Mixing both in one asset's list
made ChartsLoaded.changeDataFor throw "Cannot compare money in
different currencies". Round-trip the requested currency through
currencyFromApiString before loading so API and cached rows match,
falling back to the original currency when it can't be parsed.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VWCtnJuzXyYpP7nMbgyaKk

* Map AVAX title to avaxc in CryptoCurrency.fromString

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VWCtnJuzXyYpP7nMbgyaKk

* Charts: drop fallback now that every picker currency round-trips

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VWCtnJuzXyYpP7nMbgyaKk

* Charts: drop comment

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VWCtnJuzXyYpP7nMbgyaKk

---------

Co-authored-by: Claude <noreply@anthropic.com>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit fixes a non-security crash in the app's price charts. The chart screen could mix cached and freshly downloaded price rows that were tagged with slightly different currency names (for example, 'usdterc20' versus plain 'usdt'), causing a 'Cannot compare money in different currencies' error. The fix makes the chart request prices using the same currency tag that the cache uses, so the two sources line up. It also adds a missing nickname mapping for the AVAX token. There is no indication this was a security vulnerability or that it could be exploited.

Recommended action

No security action required. Treat as a routine bug fix. If reviewing for release stability, verify that chart price loading still works for tagged assets such as usdterc20/usdttrc20 and avax/avaxc.

Security signals we found

01

No security-relevant signals observed in the diff

02

Fix is a UI/data-consistency crash, not a vulnerability

03

No untrusted input handling, parsing, or boundary changes

04

No changes to authentication, encryption, wallet, or transaction logic

Risk score

Why this scored 18/100

Our methodology →
Potential impact 2/30
Exploitability 0/25
Stealth signal 1/15
Affected reach 3/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.