AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 20 Monero

don't run Zcash address init twice when opening a wallet (#3784)

Public commit record

What the developer wrote

Authored by malik1004x

81/100 · Strong
don't run Zcash address init twice when opening a wallet (#3784)

The ZcashWalletAddresses constructor set addressPageType through its setter, which calls init(). ZcashWallet.init() then runs walletAddresses.init() again, so every create/open/restore did the full address init (rotation pool queries plus an address book save, ~1 s on a low-end phone) twice in parallel. Set the backing field in the constructor instead; ZcashWallet.init() always follows and applies the address type.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This is a performance fix, not a security fix. When opening or creating a Zcash wallet, the app was accidentally running the same address-setup work twice in parallel. The change makes the wallet do it once, saving about a second on slow phones. There is no indication this caused funds to be lost, stolen, or misdirected.

Recommended action

Treat as a routine performance/reliability improvement. No security response required. If desired, verify that no other wallet address classes use a setter that triggers init() inside a constructor.

Security signals we found

01

Redundant initialization removed

02

Potential race condition between parallel init passes eliminated

03

No cryptographic, authentication, or authorization changes

04

No input validation or boundary changes

Risk score

Why this scored 20/100

Our methodology →
Potential impact 2/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 5/15
Confidence 9/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.