light mode fixes

Cake Wallet/Cake Wallet / Monero.com

6d288832 View source ↗

Public commit record

What the developer wrote

Authored by Robert Malikowski

28/100 · Opaque

light mode fixes

✓ Subject identifies a change! No meaningful explanatory body

The short version

What changed, and why it matters

This commit is a cosmetic fix for the app's light mode theme. It changes several buy/sell screens so they display light-colored icons when the device is in light mode, instead of always showing dark-colored icons. There is no security issue here.

Recommended action

No security action needed. Treat as a normal UI/theme fix.

Security signals we found

No strong security signals were identified.

Technical analysis

Evidence from the diff

The patch updates four Dart UI pages under lib/new-ui/pages/buy_sell/ to select icon assets based on the current theme brightness. Previously these pages unconditionally used the darkIconPath property. Now they use Theme.of(context).brightness == Brightness.light ? …lightIconPath : …darkIconPath. This is purely a UI/theming correction with no functional, cryptographic, or network behavior changes.

Changed components

lib/new-ui/pages/buy_sell/buy_sell_confirmation_page.dartlib/new-ui/pages/buy_sell/buy_sell_payment_method_page.dartlib/new-ui/pages/buy_sell/buy_sell_provider_page.dartlib/new-ui/pages/buy_sell/buy_sell_redirecting_page.dart

Inspect captured patch +13 / −5

diff --git a/lib/new-ui/pages/buy_sell/buy_sell_confirmation_page.dart b/lib/new-ui/pages/buy_sell/buy_sell_confirmation_page.dart
index 5de696f7..88fafa07 100644
--- a/lib/new-ui/pages/buy_sell/buy_sell_confirmation_page.dart
+++ b/lib/new-ui/pages/buy_sell/buy_sell_confirmation_page.dart
@@ -70,7 +70,9 @@ class BuySellConfirmationPage extends StatelessWidget {
                                 spacing: 8,
                                 children: [
                                   CakeImageWidget(
-                                    imageUrl: buySellViewModel.selectedQuote!.darkIconPath,
+                                    imageUrl: Theme.of(context).brightness == Brightness.light
+                                        ? buySellViewModel.selectedQuote!.lightIconPath
+                                        : buySellViewModel.selectedQuote!.darkIconPath,
                                     width: 24,
                                     height: 24,
                                   ),
diff --git a/lib/new-ui/pages/buy_sell/buy_sell_payment_method_page.dart b/lib/new-ui/pages/buy_sell/buy_sell_payment_method_page.dart
index e1ca3f44..c4ad495d 100644
--- a/lib/new-ui/pages/buy_sell/buy_sell_payment_method_page.dart
+++ b/lib/new-ui/pages/buy_sell/buy_sell_payment_method_page.dart
@@ -44,7 +44,9 @@ class BuySellPaymentMethodPage extends StatelessWidget {
                         keyValue: item.title,
                         label: item.title,
                         showArrow: false,
-                        iconPath: item.darkIconPath,
+                    iconPath: Theme.of(context).brightness == Brightness.light
+                            ? item.lightIconPath
+                            : item.darkIconPath,
                         iconColor: item.paymentMethodType.isMonochromeIcon
                             ? Theme.of(context).colorScheme.onSurfaceVariant
                             : null,
diff --git a/lib/new-ui/pages/buy_sell/buy_sell_provider_page.dart b/lib/new-ui/pages/buy_sell/buy_sell_provider_page.dart
index f7cbf571..64d9f95a 100644
--- a/lib/new-ui/pages/buy_sell/buy_sell_provider_page.dart
+++ b/lib/new-ui/pages/buy_sell/buy_sell_provider_page.dart
@@ -143,8 +143,10 @@ class _BuySellProviderPageState extends State<BuySellProviderPage> {
       secondaryLabel: quote.rampName != null ? quote.provider.title : null,
       subtitle: quote.badges.isEmpty ? null : quote.badges.join(" - "),
       subtitleColor: Theme.of(context).colorScheme.primary,
-      iconPath: quote.darkIconPath,
-      onTap: () {
+        iconPath: Theme.of(context).brightness == Brightness.light
+            ? quote.lightIconPath
+            : quote.darkIconPath,
+        onTap: () {
         widget.buySellViewModel.changeOption(quote);
         navigateToConfirmation(context);
       },
diff --git a/lib/new-ui/pages/buy_sell/buy_sell_redirecting_page.dart b/lib/new-ui/pages/buy_sell/buy_sell_redirecting_page.dart
index f96531b8..c4b614de 100644
--- a/lib/new-ui/pages/buy_sell/buy_sell_redirecting_page.dart
+++ b/lib/new-ui/pages/buy_sell/buy_sell_redirecting_page.dart
@@ -84,7 +84,9 @@ class _BuySellRedirectingPageState extends State<BuySellRedirectingPage> {
                         spacing: 24,
                         children: [
                           CakeImageWidget(
-                            imageUrl: widget.buySellViewModel.selectedQuote!.darkIconPath,
+                            imageUrl: Theme.of(context).brightness == Brightness.light
+                                ? widget.buySellViewModel.selectedQuote!.lightIconPath
+                                : widget.buySellViewModel.selectedQuote!.darkIconPath,
                             width: 64,
                             height: 64,
                           ),

Risk score

Why this scored 15/100

Our methodology →

Potential impact 0/30

Exploitability 0/25

Stealth signal 0/15

Affected reach 0/15

Confidence 10/10

Evidence quality 5/5

Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

What the developer wrote

What changed, and why it matters

Security signals we found

Evidence from the diff

Changed components

Why this scored 15/100

Community notes

Related watches

fix: add new images and fix integration tests (#3679)

Add Robinhood Chain (#3398)

chore: migrate to hosted scalable CI (#3620)