fix: Remove check for zero transaction amounts in transactions page (#2559)
What the developer wrote
Authored by David Adegoke
fix: Remove check for zero transaction amounts in transactions page (#2559)
* fix: Polygon transactions not coming up in transactions history page
* fix: Filter out polygon spam transactions
* fix: Remove check for zero transaction amounts in transactions page
* fix: remove redundant check for zero transaction amounts in transactions page
What changed, and why it matters
This commit removes a UI filter that previously hid transactions with a zero amount from the wallet's transaction history page. The change means users will now see zero-amount transactions (for example, some Polygon spam transactions or failed/minimal transfers) in their history instead of them being hidden. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a usability fix to ensure legitimate transactions are not accidentally hidden.
No immediate security action required. Treat as a routine UI/UX fix. If spam visibility becomes a user-harassment concern, consider adding an explicit user-controlled spam filter rather than silently hiding transactions by amount.
Security signals we found
UI filter removed, potentially exposing users to zero-amount/spam transactions
No input validation, cryptographic, or transaction-signing changes
No mention of security impact in commit message or diff
Evidence from the diff
The patch removes a single guard clause in lib/src/screens/dashboard/pages/transactions_page.dart that returned an empty Container when item.transaction.amount == 0.0. After the change, zero-amount transactions are rendered like any other transaction. The commit message frames this as fixing Polygon transactions not appearing and filtering Polygon spam, but the final diff simply removes the zero-amount check. No logic for spam classification or amount validation is added. The change is purely presentational and does not alter transaction processing, signing, or balance calculation.
Changed components
lib/src/screens/dashboard/pages/transactions_page.dartTransaction history list UIInspect captured patch +0 / −2
diff --git a/lib/src/screens/dashboard/pages/transactions_page.dart b/lib/src/screens/dashboard/pages/transactions_page.dart
index 46bd00a3..6afd2f6a 100644
--- a/lib/src/screens/dashboard/pages/transactions_page.dart
+++ b/lib/src/screens/dashboard/pages/transactions_page.dart
@@ -90,8 +90,6 @@ class TransactionsPage extends StatelessWidget {
return Container();
}
- if (item.transaction.amount == 0.0) return Container();
-
final transaction = item.transaction;
final transactionType =
dashboardViewModel.getTransactionType(transaction);
Why this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.