AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 51 Monero

fix: make the wallet-access 2FA step non-dismissable (CW-1711) (#3742)

Public commit record

What the developer wrote

Authored by Seth For Privacy

93/100 · Strong
fix: make the wallet-access 2FA step non-dismissable (CW-1711) (#3742)

* fix: make the wallet-access 2FA step non-dismissable

TotpAuthCodePage ignored isClosable since the New Design rewrite (#2797):
the back arrow was always shown and popped the route. On the resume lock
that returned to the app without the TOTP code; on cold start it left a
black screen. The Android back gesture could pop it too.

Hide the back arrow and block pops with PopScope when isClosable is false.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix: keep the 2FA page title when the back arrow is hidden

Without a leading button ModalTopBar's row has no height and clips the title.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit fixes a bug in Cake Wallet's two-factor authentication (2FA) screen. Previously, when the app required a 2FA code to unlock the wallet, users could bypass that requirement by pressing the back arrow or using Android's back gesture. The fix removes the back arrow and blocks the back gesture when the screen is meant to be mandatory, so the wallet cannot be accessed without entering the 2FA code.

Recommended action

Review other security-critical screens (PIN, password, seed phrase access) to ensure they also use PopScope or equivalent non-dismissable guards. Verify that the isClosable flag is correctly passed from all call sites, especially the resume lock and cold-start flows.

Security signals we found

01

2FA bypass via UI dismissal

02

Authentication gate not enforced on back navigation

03

Cold-start/resume lock screen bypass

04

Missing PopScope/canPop guard on security-critical route

Risk score

Why this scored 51/100

Our methodology →
Potential impact 12/30
Exploitability 10/25
Stealth signal 8/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.