fix conflict resolve issue (#2812)
What the developer wrote
Authored by Omar Hatem
fix conflict resolve issue (#2812)
What changed, and why it matters
This commit fixes two minor problems introduced when earlier code changes were merged together. One file had an unused import removed, and another file corrected a typo where a function was being called with square brackets instead of parentheses. The typo only affected the Zcash wallet fee-priority setting and would have caused a compile-time or runtime error rather than a silent security issue.
No security action required; treat as a normal code-quality/bug-fix merge.
Security signals we found
No security-relevant behavior change
Fixes a syntax/merge-conflict regression
No input validation, cryptography, or authorization changes
Evidence from the diff
The diff is a post-merge cleanup: (1) lib/core/wallet_creation_service.dart removes an unused hive import; (2) lib/view_model/send/fees_view_model.dart changes _settingsStore.setPriority[wallet.type] = ... to _settingsStore.setPriority(wallet.type, ...). The bracket syntax was invalid for a method call and would fail. There is no security-sensitive logic change.
Changed components
lib/core/wallet_creation_service.dartlib/view_model/send/fees_view_model.dartInspect captured patch +1 / −2
diff --git a/lib/core/wallet_creation_service.dart b/lib/core/wallet_creation_service.dart
index 69e9245e..27167bcc 100644
--- a/lib/core/wallet_creation_service.dart
+++ b/lib/core/wallet_creation_service.dart
@@ -2,7 +2,6 @@ import 'package:cake_wallet/di.dart';
import 'package:cake_wallet/store/settings_store.dart';
import 'package:cw_core/wallet_info.dart';
import 'package:cake_wallet/entities/preferences_key.dart';
-import 'package:hive/hive.dart';
import 'package:shared_preferences/shared_preferences.dart';
import 'package:cake_wallet/core/key_service.dart';
import 'package:cw_core/wallet_base.dart';
diff --git a/lib/view_model/send/fees_view_model.dart b/lib/view_model/send/fees_view_model.dart
index 6bda3396..cb3b596a 100644
--- a/lib/view_model/send/fees_view_model.dart
+++ b/lib/view_model/send/fees_view_model.dart
@@ -188,7 +188,7 @@ abstract class FeesViewModelBase extends WalletChangeListenerViewModel with Stor
_settingsStore.setPriority(wallet.type, monero!.getMoneroTransactionPriorityAutomatic());
break;
case WalletType.zcash:
- _settingsStore.setPriority[wallet.type] = zcash!.getZcashTransactionPriorityAutomatic();
+ _settingsStore.setPriority(wallet.type, zcash!.getZcashTransactionPriorityAutomatic());
break;
case WalletType.bitcoin:
_settingsStore.setPriority(wallet.type, bitcoin!.getBitcoinTransactionPriorityMedium());
Why this scored 16/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.