[performance] write wallet addresses to the database in one batch (#3772)
What changed, and why it matters
This commit is a performance optimization, not a security fix. It changes how a cryptocurrency wallet app saves address book data to its local database so that many records are written in one batch instead of one at a time. This reduces delays, especially when creating a new wallet, but does not change what data is stored or how it is protected.
No security action required. Treat as a routine performance improvement. If desired, verify through profiling that batch commit reduces UI jank during wallet creation.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch refactors sqflite database writes in cw_core/lib/wallet_info.dart and cw_core/lib/wallet_addresses.dart. Previously, setAddresses, setAddressInfos, setUsedAddresses, setHiddenAddresses, and setManualAddresses each deleted existing rows and inserted new rows one by one, causing many transactions/platform-channel round trips. The new code uses sqflite’s Batch API to perform each replacement (delete + inserts) in a single commit, and adds a setAddressesInBatch helper that combines all five table updates into one batch. The data model, SQL schema, and access controls are unchanged.
Changed components
cw_core/lib/wallet_addresses.dartcw_core/lib/wallet_info.dartInspect captured patch +111 / −62
### cw_core/lib/wallet_addresses.dart
@@ -71,12 +71,13 @@ abstract class WalletAddresses {
Future<void> saveAddressesInBox() async {
try {
walletInfo.address = address;
- // TODO: check if it will affect the performance of each wallet
- await walletInfo.setAddresses(addressesMap);
- await walletInfo.setAddressInfos(addressInfos);
- await walletInfo.setUsedAddresses(usedAddresses.toList());
- await walletInfo.setHiddenAddresses(hiddenAddresses.toList());
- await walletInfo.setManualAddresses(manualAddresses.toList());
+ await walletInfo.setAddressesInBatch(
+ addresses: addressesMap,
+ addressInfos: addressInfos,
+ usedAddresses: usedAddresses.toList(),
+ hiddenAddresses: hiddenAddresses.toList(),
+ manualAddresses: manualAddresses.toList(),
+ );
await walletInfo.save();
} catch (e) {
### cw_core/lib/wallet_info.dart
@@ -90,15 +90,33 @@ class WalletInfoAddressInfo {
required String address,
required String label,
}) async {
- return await db!.insert(tableName, {
- "walletInfoId": walletInfoId,
- "mapKey": mapKey,
- "mapValueAccountIndex": accountIndex,
- "mapValueAddress": address,
- "mapValueLabel": label,
- });
+ return await db!.insert(
+ tableName,
+ row(
+ walletInfoId: walletInfoId,
+ mapKey: mapKey,
+ accountIndex: accountIndex,
+ address: address,
+ label: label,
+ ),
+ );
}
+ static Map<String, Object> row({
+ required int walletInfoId,
+ required int mapKey,
+ required int accountIndex,
+ required String address,
+ required String label,
+ }) =>
+ {
+ "walletInfoId": walletInfoId,
+ "mapKey": mapKey,
+ "mapValueAccountIndex": accountIndex,
+ "mapValueAddress": address,
+ "mapValueLabel": label,
+ };
+
Map<String, dynamic> toJson() {
return {
selfIdColumn: id,
@@ -149,13 +167,15 @@ class WalletInfoAddressMap {
}
static Future<int> insert(int walletInfoId, String addressKey, String addressValue) async {
- return await db!.insert(tableName, {
- "walletInfoId": walletInfoId,
- "addressKey": addressKey,
- "addressValue": addressValue,
- });
+ return await db!.insert(tableName, row(walletInfoId, addressKey, addressValue));
}
+ static Map<String, Object> row(int walletInfoId, String addressKey, String addressValue) => {
+ "walletInfoId": walletInfoId,
+ "addressKey": addressKey,
+ "addressValue": addressValue,
+ };
+
Map<String, dynamic> toJson() {
return {
selfIdColumn: id,
@@ -218,13 +238,15 @@ class WalletInfoAddress {
if (select.isNotEmpty) {
return select[0][selfIdColumn] as int;
}
- return await db!.insert(tableName, {
- "walletInfoId": walletInfoId,
- "type": type.index,
- "address": address,
- });
+ return await db!.insert(tableName, row(walletInfoId, type, address));
}
+ static Map<String, Object> row(int walletInfoId, WalletInfoAddressType type, String address) => {
+ "walletInfoId": walletInfoId,
+ "type": type.index,
+ "address": address,
+ };
+
Map<String, dynamic> toJson() {
return {
selfIdColumn: id,
@@ -504,14 +526,66 @@ class WalletInfo {
return Map.fromEntries(list.map((e) => MapEntry(e.addressKey, e.addressValue)));
}
- Future<void> setAddresses(Map<String, String> addresses) async {
- await WalletInfoAddressMap.deleteByWalletInfoId(internalId);
- final entries = addresses.entries.toList();
- for (final entry in entries) {
- await WalletInfoAddressMap.insert(internalId, entry.key, entry.value);
+ Future<void> setAddresses(Map<String, String> addresses) =>
+ _commitBatch((batch) => _batchAddresses(batch, addresses));
+
+ Future<void> _commitBatch(void Function(Batch batch) fill) async {
+ final batch = db!.batch();
+ fill(batch);
+ await batch.commit(noResult: true);
+ }
+
+ void _batchAddresses(Batch batch, Map<String, String> addresses) {
+ batch.delete(WalletInfoAddressMap.tableName,
+ where: 'walletInfoId = ?', whereArgs: [internalId]);
+ for (final entry in addresses.entries.toList()) {
+ batch.insert(
+ WalletInfoAddressMap.tableName, WalletInfoAddressMap.row(internalId, entry.key, entry.value));
+ }
+ }
+
+ void _batchAddressInfos(Batch batch, Map<int, List<WalletInfoAddressInfo>> addressInfos) {
+ batch.delete(WalletInfoAddressInfo.tableName,
+ where: 'walletInfoId = ?', whereArgs: [internalId]);
+ for (final addressInfo in addressInfos.entries.toList()) {
+ for (final info in addressInfo.value.toList()) {
+ batch.insert(
+ WalletInfoAddressInfo.tableName,
+ WalletInfoAddressInfo.row(
+ walletInfoId: internalId,
+ mapKey: addressInfo.key,
+ accountIndex: info.accountIndex,
+ address: info.address,
+ label: info.label,
+ ),
+ );
+ }
+ }
+ }
+
+ void _batchAddressesOfType(Batch batch, WalletInfoAddressType type, List<String> addresses) {
+ batch.delete(WalletInfoAddress.tableName,
+ where: 'walletInfoId = ? AND type = ?', whereArgs: [internalId, type.index]);
+ for (final address in addresses.toSet()) {
+ batch.insert(WalletInfoAddress.tableName, WalletInfoAddress.row(internalId, type, address));
}
}
+ Future<void> setAddressesInBatch({
+ required Map<String, String> addresses,
+ required Map<int, List<WalletInfoAddressInfo>> addressInfos,
+ required List<String> usedAddresses,
+ required List<String> hiddenAddresses,
+ required List<String> manualAddresses,
+ }) =>
+ _commitBatch((batch) {
+ _batchAddresses(batch, addresses);
+ _batchAddressInfos(batch, addressInfos);
+ _batchAddressesOfType(batch, WalletInfoAddressType.used, usedAddresses);
+ _batchAddressesOfType(batch, WalletInfoAddressType.hidden, hiddenAddresses);
+ _batchAddressesOfType(batch, WalletInfoAddressType.manual, manualAddresses);
+ });
+
String? yatEid;
String? yatLastUsedAddressRaw;
bool? showIntroCakePayCard;
@@ -526,58 +600,32 @@ class WalletInfo {
return ret;
}
- Future<void> setAddressInfos(Map<int, List<WalletInfoAddressInfo>> addressInfos) async {
- await WalletInfoAddressInfo.deleteByWalletInfoId(internalId);
- final entries = addressInfos.entries.toList();
- for (final addressInfo in entries) {
- final infoList = addressInfo.value.toList();
- for (final info in infoList) {
- await WalletInfoAddressInfo.insert(
- walletInfoId: internalId,
- mapKey: addressInfo.key,
- accountIndex: info.accountIndex,
- address: info.address,
- label: info.label,
- );
- }
- }
- }
+ Future<void> setAddressInfos(Map<int, List<WalletInfoAddressInfo>> addressInfos) =>
+ _commitBatch((batch) => _batchAddressInfos(batch, addressInfos));
Future<Set<String>> getUsedAddresses() async {
final list = await WalletInfoAddress.selectList(internalId, WalletInfoAddressType.used);
return list.map((e) => e.address).toSet();
}
- Future<void> setUsedAddresses(List<String> addresses) async {
- await WalletInfoAddress.deleteByType(internalId, WalletInfoAddressType.used);
- for (final address in addresses) {
- await WalletInfoAddress.insert(internalId, WalletInfoAddressType.used, address);
- }
- }
+ Future<void> setUsedAddresses(List<String> addresses) =>
+ _commitBatch((batch) => _batchAddressesOfType(batch, WalletInfoAddressType.used, addresses));
Future<Set<String>> getHiddenAddresses() async {
final list = await WalletInfoAddress.selectList(internalId, WalletInfoAddressType.hidden);
return list.map((e) => e.address).toSet();
}
- Future<void> setHiddenAddresses(List<String> addresses) async {
- await WalletInfoAddress.deleteByType(internalId, WalletInfoAddressType.hidden);
- for (final address in addresses) {
- await WalletInfoAddress.insert(internalId, WalletInfoAddressType.hidden, address);
- }
- }
+ Future<void> setHiddenAddresses(List<String> addresses) =>
+ _commitBatch((batch) => _batchAddressesOfType(batch, WalletInfoAddressType.hidden, addresses));
Future<Set<String>> getManualAddresses() async {
final list = await WalletInfoAddress.selectList(internalId, WalletInfoAddressType.manual);
return list.map((e) => e.address).toSet();
}
- Future<void> setManualAddresses(List<String> addresses) async {
- await WalletInfoAddress.deleteByType(internalId, WalletInfoAddressType.manual);
- for (final address in addresses) {
- await WalletInfoAddress.insert(internalId, WalletInfoAddressType.manual, address);
- }
- }
+ Future<void> setManualAddresses(List<String> addresses) =>
+ _commitBatch((batch) => _batchAddressesOfType(batch, WalletInfoAddressType.manual, addresses));
Future<void> addAddress(String address, WalletInfoAddressType type) async {
await WalletInfoAddress.insert(internalId, type, address);Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.