AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 63 Bitcoin

Fix LNURL authentication, rate expansion and subscription credit rounding (#7762)

Public commit record

What the developer wrote

Authored by Nicolas Dorier

63/100 · Adequate
Fix LNURL authentication, rate expansion and subscription credit rounding (#7762)
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes several unrelated bugs in BTCPay Server. The most security-relevant changes are: (1) LNURL authentication now uses expiring challenges tied to a user's security stamp, preventing old or stale login challenges from being reused; (2) notifications are now filtered by store permission policy, so users without the right role no longer receive sensitive payout/invoice notifications; (3) subscription credit rounding is changed so customers cannot be credited more than they actually paid; and (4) a memory-cache fix prevents lightning address lookups from returning stale null results. The rate-rule change adds a length limit to prevent very large nested rate expressions from being processed.

Recommended action

Review and deploy this patch promptly. Validate LNURL auth flows, confirm notification recipients match expected store roles, and verify subscription credit calculations do not exceed paid amounts. Consider adding regression tests for stale LNURL challenge reuse and notification policy filtering.

Security signals we found

01

LNURL auth challenge reuse / stale-k1 issue mitigated by expiration and security-stamp binding

02

Store notifications now scoped by permission policy, reducing information disclosure to under-privileged users

03

Subscription credit rounding changed to prevent over-crediting customers

04

Rate expression flattening bounded by maximum length to limit CPU/memory consumption

05

Memory-cache no longer caches missing lightning-address lookups, preventing stale negative cache hits

Risk score

Why this scored 63/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 10/15
Affected reach 12/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.