AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 57 Bitcoin

Reject workflow state from seed signing links

Public commit record

What the developer wrote

Authored by Nicolas Dorier

45/100 · Thin
Reject workflow state from seed signing links
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit changes how BTCPay Server handles wallet signing links that use a stored seed. Previously, clicking a 'seed' signing link could automatically carry over a pending transaction and original PSBT (a partially-signed Bitcoin transaction) from the user's workflow state. The patch makes the seed signing page discard that workflow state and only accept signing context supplied directly in the link. This likely closes a security issue where a malicious or crafted link could trick a user into signing a different transaction than expected by reusing state from a previous session.

Recommended action

Review whether other signing methods (vault, hardware wallet, etc.) similarly sanitize workflow state before rendering signing pages. Consider adding tests that verify a seed signing link with a stale PendingTransactionId does not sign the wrong PSBT. No immediate emergency action is indicated, but the fix should be included in the next release.

Security signals we found

01

State-clearing before sensitive signing operation

02

Separation of stateful entry point from direct view rendering

03

Prevents reuse of PendingTransactionId/OriginalPSBT from prior workflow state

04

Title explicitly frames change as 'Reject workflow state from seed signing links'

Risk score

Why this scored 57/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 10/15
Affected reach 8/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.