AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 49 Bitcoin

Harden payment and wallet validation (#7664)

Public commit record

What the developer wrote

Authored by Nicolas Dorier

53/100 · Thin
Harden payment and wallet validation (#7664)
✓ Descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes several input-validation bugs in BTCPay Server. The most important change corrects a logic error in store settings validation: previously, expiration times were only rejected if they were simultaneously too short AND too long, which effectively allowed any value. The commit also blocks negative or zero amounts for Lightning payments and LNURL invoices, prevents crashes when parsing malformed wallet backup files, and fixes a charting bug for empty wallets. These are hardening fixes rather than a single critical vulnerability.

Recommended action

Review and merge the patch, then ensure the new validation rules are enforced server-side for all API clients. Consider whether the corrected store expiration validation should be backported, as the prior logic effectively disabled the intended limits.

Security signals we found

01

Validation logic bug: && instead of || allowed out-of-range store expiration values

02

Negative/zero amount accepted for Lightning invoice payment and LNURL pay

03

Unhardened BSMS wallet file parsing could throw on malformed input

04

Missing null check on exchange rate before creating refund pull payment

05

Empty wallet histogram series could cause index-out-of-range/corrupted data

Risk score

Why this scored 49/100

Our methodology →
Potential impact 12/30
Exploitability 10/25
Stealth signal 6/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.