AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 55 Bitcoin

Merge pull request #7713 from btcpayserver/security/seed-signing-pending-id

Public commit record

What the developer wrote

Authored by Nicolas Dorier

78/100 · Adequate
Merge pull request #7713 from btcpayserver/security/seed-signing-pending-id

Require transaction review for linked seed signing
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
The short version

What changed, and why it matters

This commit changes how BTCPay Server handles signing cryptocurrency transactions with a stored wallet seed. Previously, a user could be sent straight to the seed-signing screen carrying a pre-loaded transaction (a 'pending transaction' and original PSBT). The patch forces that screen to drop any pre-loaded transaction data, so the user must review the transaction before signing. In short, it removes a path that could let an attacker trick someone into signing a transaction they never saw. The rest of the changes are just test and UI tweaks for the Pay Button feature and are not security-related.

Recommended action

Treat this as a security hardening fix and include it in the next release. Users running affected versions should upgrade. Review whether any other signing paths (hardware wallet, vault, hot wallet) similarly allow pre-loaded transactions to bypass review.

Security signals we found

01

Clearing of PendingTransactionId and OriginalPSBT before rendering seed-signing view

02

Separation of HTTP GET entry point from view-rendering helper to control context flow

03

Pull request branch named security/seed-signing-pending-id

04

Commit title explicitly references 'Require transaction review for linked seed signing'

Risk score

Why this scored 55/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 7/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.