What the developer wrote
Authored by Nicolas Dorier
Fix flaky test
What changed, and why it matters
This is a one-line change in an automated test file. It makes the test wait for a web page modal to be fully visible before clicking a button, which should make the test less likely to fail randomly. There is no change to production code and no security relevance.
No security action needed. This is a routine test reliability fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies BTCPayServer.Tests/SubscriptionTests.cs. The Playwright test selector is changed from s.Page.ClickAsync("#newSubscriberModal button[name='command']") to s.Page.Locator("#newSubscriberModal.show button[name='command']").ClickAsync(). The addition of the .show class ensures the modal is visible before interaction, addressing a race condition that caused test flakiness. No application code is changed.
Changed components
BTCPayServer.Tests/SubscriptionTests.csInspect captured patch +1 / −1
### BTCPayServer.Tests/SubscriptionTests.cs
@@ -1028,7 +1028,7 @@ public async Task NewSubscriber(string planName, string email, bool hasTrial, bo
await s.Page.CheckAsync("input[name='isTrial']");
else
Assert.False(await s.Page.Locator("input[name='isTrial']").IsVisibleAsync());
- await s.Page.ClickAsync("#newSubscriberModal button[name='command']");
+ await s.Page.Locator("#newSubscriberModal.show button[name='command']").ClickAsync();
await s.Page.FillAsync("#emailInput", email);
await s.Page.ClickAsync("button[name='command']");
if (!allowTrial && hasInvoice is not false)Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.