What the developer wrote
Authored by Nicolas Dorier
Fix flaky test
What changed, and why it matters
This commit only changes a test helper file used in automated UI testing. It replaces a manual sequence of keyboard shortcuts with calls to existing helper methods that do the same thing, in order to make a flaky test more reliable. There is no change to production code and no security relevance.
No security action needed. Treat as routine test maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies BTCPayServer.Tests/PMO/GlobalSearchPMO.cs, a Playwright page-object helper. The GoToPage method previously waited for the global search input, pressed ‘/’, typed the page name, and pressed Enter. The patch replaces that inline sequence with calls to the existing Fill(query) and Enter() helper methods. This is a test-code refactoring to reduce flakiness; no application code is touched.
Changed components
BTCPayServer.Tests/PMO/GlobalSearchPMO.csInspect captured patch +2 / −4
diff --git a/BTCPayServer.Tests/PMO/GlobalSearchPMO.cs b/BTCPayServer.Tests/PMO/GlobalSearchPMO.cs
index 6f955c0..7a69271 100644
--- a/BTCPayServer.Tests/PMO/GlobalSearchPMO.cs
+++ b/BTCPayServer.Tests/PMO/GlobalSearchPMO.cs
@@ -13,10 +13,8 @@ public class GlobalSearchPMO(PlaywrightTester tester)
/// <param name="page"></param>
public async Task GoToPage(string page)
{
- await Page.Locator("#globalSearchInput").WaitForAsync();
- await Page.Keyboard.PressAsync("/");
- await Page.Keyboard.TypeAsync(page);
- await Page.Keyboard.PressAsync("Enter");
+ await Fill(page);
+ await Enter();
}
public async Task Fill(string query)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.