AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 60 Bitcoin

Support translation repository redirects and BCP 47 identifiers

Public commit record

What the developer wrote

Authored by Chukwuleta Tobechi

73/100 · Adequate
Support translation repository redirects and BCP 47 identifiers

Allow translation manifests to delegate to another BTCPay Server repository and expose standardized language tags. Validate manifest and pack download destinations, disable automatic HTTP redirects, and resolve pack URIs relative to the manifest with BOM-aware decoding.

Co-authored-by: r1ckstardev <r1ckstardev@users.noreply.github.com>
Co-authored-by: Nicolas Dorier <nicolas.dorier@gmail.com>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit hardens how BTCPay Server downloads translation files from the internet. It adds checks so the server only fetches language packs and manifest redirects from the trusted btcpayserver GitHub organization, turns off automatic HTTP redirects, and handles UTF-8 text files that start with a special byte marker. The changes appear to be defensive security improvements rather than a fix for a known active attack.

Recommended action

Treat as a security-hardening change and include in the next release. Review whether the trusted-org check (raw.githubusercontent.com/btcpayserver/*) is sufficiently strict for your threat model, and confirm that any custom translation repositories are hosted under that exact path. No immediate emergency response is indicated by the diff alone.

Security signals we found

01

Server-side request forgery (SSRF) hardening: URI scheme, host, and path prefix are validated before outbound fetch

02

Open-redirect / HTTP redirect abuse mitigation: AllowAutoRedirect set to false on the translation HttpClient

03

Path traversal mitigation: pack file paths resolved as relative URIs and validated against trusted org prefix

04

Manifest redirect delegation added with same trust-boundary validation

05

BOM-aware manifest parsing added to avoid JSON parse failures on UTF-8 BOM

06

New test cases explicitly model attacker-controlled redirect and file values

Risk score

Why this scored 60/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 10/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.