AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 29 Bitcoin

Merge pull request #7810 from efeesrefinal/fix/wallet-transaction-filters

Public commit record

What the developer wrote

Authored by Nicolas Dorier

73/100 · Adequate
Merge pull request #7810 from efeesrefinal/fix/wallet-transaction-filters

Fix: Wallet transactions listed twice when filtering by status and label
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit fixes two bugs in BTCPay Server's wallet transaction API. First, when users filtered transactions by both status (confirmed/unconfirmed) and label, the same transaction could appear twice in the results because the filtering logic added the transaction once for matching the label and again for matching the status. Second, two API endpoints that look up a single transaction by ID would crash if given an invalid transaction ID instead of returning a proper 'not found' error. The patch corrects the filtering logic and safely handles malformed transaction IDs.

Recommended action

No immediate security response required. This is a routine bug-fix merge. Operators should ensure they are running a version that includes this commit to avoid API errors and inconsistent wallet transaction listings. Reviewers may want to verify that other endpoints using uint256.Parse perform similar input validation.

Security signals we found

01

Fixes duplicate entries in API query results due to incorrect filter composition

02

Replaces unsafe uint256.Parse with uint256.TryParse to prevent unhandled exceptions on malformed input

03

Adds server-side input validation returning structured 404 API error for invalid transaction IDs

04

Adds regression tests for combined filter behavior and invalid transaction ID handling

Risk score

Why this scored 29/100

Our methodology →
Potential impact 5/30
Exploitability 3/25
Stealth signal 4/15
Affected reach 5/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.