What the developer wrote
Authored by Nicolas Dorier
Improve test speed
What changed, and why it matters
This commit only changes test configuration files for the BTCPay Server project. It adds the Bitcoin setting `unsafesqlitesync=1` to the docker-compose files used during automated testing. This setting makes test execution faster by relaxing how safely Bitcoin Core writes its SQLite wallet data to disk. It does not affect production BTCPay Server code or live deployments, and there is no indication it fixes or introduces a security vulnerability.
No security action required. Reviewers may optionally confirm that `unsafesqlitesync=1` is not present in any production-facing configuration templates.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff adds unsafesqlitesync=1 to three docker-compose files under BTCPayServer.Tests/. This Bitcoin Core option disables synchronous SQLite writes, improving test performance at the cost of wallet durability in case of crashes. The change is confined to test infrastructure and does not modify application code, runtime defaults, or production deployment configurations. No security relevance is stated or implied in the commit message or diff.
Changed components
BTCPayServer.Tests/docker-compose.altcoins.ymlBTCPayServer.Tests/docker-compose.testnet.ymlBTCPayServer.Tests/docker-compose.ymlInspect captured patch +6 / −0
diff --git a/BTCPayServer.Tests/docker-compose.altcoins.yml b/BTCPayServer.Tests/docker-compose.altcoins.yml
index d619e00..9c955ff 100644
--- a/BTCPayServer.Tests/docker-compose.altcoins.yml
+++ b/BTCPayServer.Tests/docker-compose.altcoins.yml
@@ -85,6 +85,7 @@ services:
connect=bitcoind:39388
fallbackfee=0.0002
rpcallowip=0.0.0.0/0
+ unsafesqlitesync=1
depends_on:
- nbxplorer
- postgres
@@ -156,6 +157,7 @@ services:
deprecatedrpc=signrawtransaction
fallbackfee=0.0002
minrelaytxfee=0.00001000
+ unsafesqlitesync=1
ports:
- "43782:43782"
- "39388:39388"
diff --git a/BTCPayServer.Tests/docker-compose.testnet.yml b/BTCPayServer.Tests/docker-compose.testnet.yml
index 06bd5cd..0d037e9 100644
--- a/BTCPayServer.Tests/docker-compose.testnet.yml
+++ b/BTCPayServer.Tests/docker-compose.testnet.yml
@@ -40,6 +40,7 @@ services:
connect=bitcoind:39388
fallbackfee=0.0002
rpcallowip=0.0.0.0/0
+ unsafesqlitesync=1
depends_on:
- nbxplorer
- postgres
@@ -88,6 +89,7 @@ services:
zmqpubrawtx=tcp://0.0.0.0:28333
deprecatedrpc=signrawtransaction
fallbackfee=0.0002
+ unsafesqlitesync=1
ports:
- "43782:43782"
- "39388:39388"
diff --git a/BTCPayServer.Tests/docker-compose.yml b/BTCPayServer.Tests/docker-compose.yml
index aba73f6..c2265ad 100644
--- a/BTCPayServer.Tests/docker-compose.yml
+++ b/BTCPayServer.Tests/docker-compose.yml
@@ -81,6 +81,7 @@ services:
connect=bitcoind:39388
fallbackfee=0.0002
rpcallowip=0.0.0.0/0
+ unsafesqlitesync=1
depends_on:
- nbxplorer
- postgres
@@ -141,6 +142,7 @@ services:
deprecatedrpc=signrawtransaction
fallbackfee=0.0002
minrelaytxfee=0.00001000
+ unsafesqlitesync=1
ports:
- "43782:43782"
- "39388:39388"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.