Tests: Port CanTranslateLoginPage to playwright (#7106)

BTCPay Server/BTCPay Server

3f52aa7f View source ↗

Public commit record

What the developer wrote

Authored by Nicolas Dorier

68/100 · Adequate

Tests: Port CanTranslateLoginPage to playwright (#7106)

✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body

The short version

What changed, and why it matters

This commit is a routine test modernization: it rewrites one existing automated UI test to use the Playwright testing framework instead of Selenium, and adds a single HTML data-testid attribute to the signed-out page header so the test can reliably locate it. There is no change to production logic, no security fix, and no vulnerability introduced.

Recommended action

No security action required. This is a test-only refactor; review and merge through normal QA process.

Security signals we found

No strong security signals were identified.

Technical analysis

Evidence from the diff

The diff ports LanguageServiceTests.CanTranslateLoginPage from Selenium to Playwright (async locators, assertions, and test helpers). It moves the ActivateLangs helper from ServerTester into the test class. It also adds data-testid=”header” to the

in _LayoutSignedOut.cshtml to support the Playwright locator. No application behavior, authentication, authorization, input handling, or cryptographic code is modified.

Changed components

BTCPayServer.Tests/LanguageServiceTests.csBTCPayServer.Tests/ServerTester.csBTCPayServer/Views/Shared/_LayoutSignedOut.cshtml

Inspect captured patch +53 / −53

diff --git a/BTCPayServer.Tests/LanguageServiceTests.cs b/BTCPayServer.Tests/LanguageServiceTests.cs
index 20527da..ff1d435 100644
--- a/BTCPayServer.Tests/LanguageServiceTests.cs
+++ b/BTCPayServer.Tests/LanguageServiceTests.cs
@@ -1,19 +1,16 @@
-using System;
 using System.Collections.Generic;
-using System.Data;
+using System.IO;
 using System.Linq;
 using System.Threading.Tasks;
-using BTCPayServer.Abstractions.Contracts;
 using BTCPayServer.Data;
 using BTCPayServer.Hosting;
 using BTCPayServer.Services;
 using Dapper;
 using Microsoft.EntityFrameworkCore;
-using OpenQA.Selenium;
-using OpenQA.Selenium.Support.Extensions;
+using Microsoft.Playwright;
+using static Microsoft.Playwright.Assertions;
 using Xunit;
 using Xunit.Abstractions;
-using static BTCPayServer.Services.LocalizerService;
 
 namespace BTCPayServer.Tests
 {
@@ -25,57 +22,71 @@ namespace BTCPayServer.Tests
         {
         }
 
+        public void ActivateLangs(ServerTester s)
+        {
+            TestLogs.LogInformation("Activating Langs...");
+            var dir = TestUtils.GetTestDataFullPath("Langs");
+            var langdir = Path.Combine(s.PayTester._Directory, "Langs");
+            Directory.CreateDirectory(langdir);
+            foreach (var file in Directory.GetFiles(dir))
+                File.Copy(file, Path.Combine(langdir, Path.GetFileName(file)));
+        }
+
         [Fact(Timeout = TestTimeout)]
-        [Trait("Selenium", "Selenium")]
+        [Trait("Playwright", "Playwright")]
         public async Task CanTranslateLoginPage()
         {
-            using var tester = CreateSeleniumTester(newDb: true);
-            tester.Server.ActivateLangs();
+            await using var tester = CreatePlaywrightTester(newDb: true);
+            ActivateLangs(tester.Server);
             await tester.StartAsync();
             await tester.Server.PayTester.RestartStartupTask<LoadTranslationsStartupTask>();
 
             // Check if the Cypherpunk translation has been loaded from the file
-            tester.RegisterNewUser(true);
-            tester.CreateNewStore();
-            tester.GoToServer(Views.Server.ServerNavPages.Translations);
-            tester.Driver.FindElement(By.Id("Select-Cypherpunk")).Click();
-            tester.Logout();
-            Assert.Contains("Cyphercode", tester.Driver.PageSource);
-            Assert.Contains("Yo at BTCPay Server", tester.Driver.PageSource);
-
-            // Create English (Custom) 
-            tester.LogIn();
-            tester.GoToServer(Views.Server.ServerNavPages.Translations);
-            tester.ClickPagePrimary();
-            tester.Driver.FindElement(By.Name("Name")).SendKeys("English (Custom)");
-            tester.ClickPagePrimary();
-            var translations = tester.Driver.FindElement(By.Name("Translations"));
-            translations.Clear();
-            translations.SendKeys("{ \"Password\": \"Mot de passe\" }");
-            tester.ClickPagePrimary();
+            await tester.RegisterNewUser(true);
+            await tester.CreateNewStore();
+            await tester.GoToServer(Views.Server.ServerNavPages.Translations);
+            await tester.Page.Locator("#Select-Cypherpunk").ClickAsync();
+            await tester.Logout();
+
+            await Expect(tester.Page.Locator("label[for=\"Password\"]")).ToContainTextAsync("Cyphercode");
+            await Expect(tester.Page.GetByTestId("header")).ToContainTextAsync("Yo at BTCPay Server");
+
+            // Create English (Custom)
+            await tester.LogIn(tester.CreatedUser);
+            await tester.GoToServer(Views.Server.ServerNavPages.Translations);
+            await tester.ClickPagePrimary();
+            await tester.Page.Locator("[name='Name']").FillAsync("English (Custom)");
+            await tester.ClickPagePrimary();
+            var translations = tester.Page.Locator("[name='Translations']");
+            await translations.ClearAsync();
+            await translations.FillAsync("{ \"Password\": \"Mot de passe\" }");
+            await tester.ClickPagePrimary();
 
             // Check English (Custom) can be selected
-            tester.Driver.FindElement(By.Id("Select-English (Custom)")).Click();
-            tester.Logout();
-            Assert.Contains("Mot de passe", tester.Driver.PageSource);
+            await tester.Page.Locator("#Select-English\\ \\(Custom\\)").ClickAsync();
+            await tester.Logout();
+            await Expect(tester.Page.Locator("label[for=\"Password\"]")).ToContainTextAsync("Mot de passe");
 
             // Check if we can remove English (Custom)
-            tester.LogIn();
-            tester.GoToServer(Views.Server.ServerNavPages.Translations);
-            var text = tester.Driver.PageSource;
+            await tester.LogIn(tester.CreatedUser);
+            await tester.GoToServer(Views.Server.ServerNavPages.Translations);
+            await tester.Page.WaitForLoadStateAsync(LoadState.DOMContentLoaded);
+            var text = await tester.Page.ContentAsync();
             Assert.Contains("Select-Cypherpunk", text);
             Assert.DoesNotContain("Select-English (Custom)", text);
             // Cypherpunk is loaded from file, can't edit
             Assert.DoesNotContain("Delete-Cypherpunk", text);
             // English (Custom) is selected, can't edit
             Assert.DoesNotContain("Delete-English (Custom)", text);
-            tester.Driver.FindElement(By.Id("Select-Cypherpunk")).Click();
-            tester.Driver.FindElement(By.Id("Delete-English (Custom)")).Click();
-            tester.Driver.WaitForElement(By.Id("ConfirmInput")).SendKeys("DELETE");
-            tester.Driver.FindElement(By.Id("ConfirmContinue")).Click();
-
-            Assert.Contains("Dictionary English (Custom) deleted", tester.FindAlertMessage().Text);
-            Assert.DoesNotContain("Select-English (Custom)", tester.Driver.PageSource);
+            await tester.Page.Locator("#Select-Cypherpunk").ClickAsync();
+            await tester.Page.Locator("#Delete-English\\ \\(Custom\\)").ClickAsync();
+            await tester.Page.Locator("#ConfirmInput").FillAsync("DELETE");
+            await tester.Page.Locator("#ConfirmContinue").ClickAsync();
+
+            var alertMessage = await tester.FindAlertMessage();
+            Assert.Contains("Dictionary English (Custom) deleted", await alertMessage.TextContentAsync());
+            var pageContent = await tester.Page.ContentAsync();
+            Assert.DoesNotContain("Select-English (Custom)", pageContent);
         }
 
         [Fact(Timeout = TestTimeout)]
@@ -197,7 +208,7 @@ namespace BTCPayServer.Tests
             Assert.NotNull(lang3);
             Assert.Equal("fr-FR", lang3?.Code);
 
-            // Unusual format, but still valid. Some language is given that we don't have and a wildcard for everything else. 
+            // Unusual format, but still valid. Some language is given that we don't have and a wildcard for everything else.
             // Result should be NULL, because "xx" does not exist and * is a wildcard and has no meaning.
             var lang4 = languageService.FindLanguageInAcceptLanguageHeader("xx,*;q=0.5");
             Assert.Null(lang4);
diff --git a/BTCPayServer.Tests/ServerTester.cs b/BTCPayServer.Tests/ServerTester.cs
index 30df114..5f8b3e3 100644
--- a/BTCPayServer.Tests/ServerTester.cs
+++ b/BTCPayServer.Tests/ServerTester.cs
@@ -84,17 +84,6 @@ namespace BTCPayServer.Tests
 
         public string Scope { get; set; }
 
-        public void ActivateLangs()
-        {
-            TestLogs.LogInformation("Activating Langs...");
-            var dir = TestUtils.GetTestDataFullPath("Langs");
-            var langdir = Path.Combine(PayTester._Directory, "Langs");
-            Directory.CreateDirectory(langdir);
-            foreach (var file in Directory.GetFiles(dir))
-                File.Copy(file, Path.Combine(langdir, Path.GetFileName(file)));
-        }
-
-
         public void ActivateLTC()
         {
             LTCExplorerNode = new RPCClient(RPCCredentialString.Parse(GetEnvironment("TESTS_LTCRPCCONNECTION", "server=http://127.0.0.1:43783;ceiwHEbqWI83:DwubwWsoo3")), NetworkProvider.GetNetwork<BTCPayNetwork>("LTC").NBitcoinNetwork);
diff --git a/BTCPayServer/Views/Shared/_LayoutSignedOut.cshtml b/BTCPayServer/Views/Shared/_LayoutSignedOut.cshtml
index bf4e4a5..206ee61 100644
--- a/BTCPayServer/Views/Shared/_LayoutSignedOut.cshtml
+++ b/BTCPayServer/Views/Shared/_LayoutSignedOut.cshtml
@@ -48,7 +48,7 @@
             <vc:main-logo />
         </a>
 
-		<h1 class="h2 mb-3">@ViewLocalizer["Welcome to {0}", string.IsNullOrWhiteSpace(settings.ServerName) ? "BTCPay Server" : settings.ServerName]</h1>
+		<h1 data-testid="header" class="h2 mb-3">@ViewLocalizer["Welcome to {0}", string.IsNullOrWhiteSpace(settings.ServerName) ? "BTCPay Server" : settings.ServerName]</h1>
         @if (ViewBag.ShowLeadText)
         {
             <p class="lead">

Risk score

Why this scored 15/100

Our methodology →

Potential impact 0/30

Exploitability 0/25

Stealth signal 0/15

Affected reach 0/15

Confidence 10/10

Evidence quality 5/5

Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

What the developer wrote

What changed, and why it matters

Security signals we found

Evidence from the diff

in _LayoutSignedOut.cshtml to support the Playwright locator. No application behavior, authentication, authorization, input handling, or cryptographic code is modified.

Changed components

Why this scored 15/100

Community notes

Related watches

Update Changelog

Disabled unwanted routes

Changelog for 2.4.2