AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 65 Bitcoin

Fix form permissions, payment updates and onion validation (#7759)

Public commit record

What the developer wrote

Authored by Nicolas Dorier

58/100 · Thin
Fix form permissions, payment updates and onion validation (#7759)
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes three separate issues in BTCPay Server: (1) private forms could be submitted by unauthorized users because permission checks were missing, (2) payment updates could trigger errors or incorrect events when multiple payments belonged to the same invoice, and (3) Tor (.onion) address validation was too simple and could be bypassed or misused. It also fixes two JavaScript error messages so they display as plain text instead of HTML, preventing possible cross-site scripting (XSS) when error content is shown to users.

Recommended action

Review and merge promptly; verify that the new authorization check covers all submission paths (including API and plugin callbacks), test .onion validation against edge cases such as trailing dots and non-DNS hostnames, and confirm the PaymentService caching does not skip necessary invoice reloads on concurrent updates. Consider adding regression tests for each fixed class of issue.

Security signals we found

01

Missing authorization check added for non-public form submissions

02

Centralized and stricter .onion hostname validation

03

Invoice blob deserialization moved out of per-payment loop to avoid duplicate work and potential event inconsistencies

04

JavaScript error toasts switched from HTML string injection to textContent nodes

05

Multiple security-relevant areas (forms, payments, onion, XSS) touched in one commit

Risk score

Why this scored 65/100

Our methodology →
Potential impact 18/30
Exploitability 14/25
Stealth signal 10/15
Affected reach 12/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.