What the developer wrote
Authored by Nicolas Dorier
Fix flaky test
What changed, and why it matters
This commit adds one extra wait/check to an automated test that verifies email rules appear in a web page. It is purely a test-stability fix and does not change any production code, user-facing behavior, or security boundary.
No security action needed. Treat as a routine test-quality improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff inserts an additional Playwright assertion await Assertions.Expect(s.Page.Locator(".table")).ToContainTextAsync("test@gmail.com"); before the existing Assert.Contains in BTCPayServer.Tests/EmailsTests.cs. This makes the test wait for the table element to contain the expected email address before reading the whole page content, reducing flakiness caused by timing. No application code is modified.
Changed components
BTCPayServer.Tests/EmailsTests.csInspect captured patch +1 / −0
### BTCPayServer.Tests/EmailsTests.cs
@@ -419,6 +419,7 @@ await pmo.Fill(new()
await s.FindAlertMessage();
// we now have a rule
Assert.DoesNotContain("There are no rules yet.", await s.Page.ContentAsync());
+ await Assertions.Expect(s.Page.Locator(".table")).ToContainTextAsync("test@gmail.com");
Assert.Contains("test@gmail.com", await s.Page.ContentAsync());
await s.GoToStore(StoreNavPages.Emails);Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.