What the developer wrote
Authored by Calvin Kim
ci: run rpctest integration tests
`make build`, `make unit-cover`, and `make unit-race` all use plain
`go test` without the rpctest build tag, so anything under
//go:build rpctest -- the entire integration/ package outside of
rpctest/, and parts of rpctest/ itself -- is not exercised by CI.
Bugs that only surface under -tags=rpctest can land on master without
detection.
Add a test-rpctest job that runs `make unit` (which sets
-tags=rpctest) so rpctest-tagged tests are part of every push and PR.
What changed, and why it matters
This commit only changes the project's continuous integration (CI) configuration. It adds a new automated test job that runs a previously skipped set of tests tagged with 'rpctest'. There is no change to application code, no bug fix, and no security patch.
No security action required. Treat as a normal CI/infrastructure improvement. Optionally review the rpctest-tagged tests themselves for coverage and reliability, since they will now run automatically.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff adds a GitHub Actions job named ‘Unit rpctest’ to .github/workflows/main.yml. The job runs make unit, which passes -tags=rpctest to go test, so tests guarded by the rpctest build tag are now exercised on every push and PR. Existing jobs (make build, make unit-cover, make unit-race) use plain go test without the tag, leaving rpctest-tagged code untested. This commit closes that CI gap but does not modify any source code or fix any vulnerability.
Changed components
.github/workflows/main.ymlInspect captured patch +15 / −0
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 3fb2f37..f6394a9 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -145,3 +145,18 @@ jobs:
- name: Test
run: make unit-race
+
+ test-rpctest:
+ name: Unit rpctest
+ runs-on: ubuntu-latest
+ steps:
+ - name: Set up Go
+ uses: actions/setup-go@v5
+ with:
+ go-version: ${{ env.GO_VERSION }}
+
+ - name: Check out source
+ uses: actions/checkout@v4
+
+ - name: Test
+ run: make unit
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.