What the developer wrote
Authored by Jon Griffiths
qemu: fix qemu_run/qemu_gdb
Fix pipefail piping into the true builtin instead of using it to ensure
pkill doesn't fail. Then remove pipefail becuase its redundant in these
scripts.
What changed, and why it matters
This commit fixes two developer helper scripts used to launch a QEMU emulator for testing. The changes correct a shell scripting mistake (using a pipe to 'true' instead of '|| true') and make the scripts more portable by using '/usr/bin/env bash'. There is no security issue here; it is a routine bugfix for internal development tooling.
No security action needed. Treat as a normal development/CI script fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies main/qemu/qemu_gdb.sh and main/qemu/qemu_run.sh. It replaces ‘pkill -f qemu-system-xtensa | true’ with ‘pkill … || true’, which is the idiomatic way to ignore a potential nonzero exit from pkill. It also switches the shebang from ‘#!/bin/bash’ to ‘#!/usr/bin/env bash’ and conditionally sources the ESP-IDF environment only when IDF_PATH is unset. These are correctness and portability improvements in local development scripts, not in firmware or production code.
Changed components
main/qemu/qemu_gdb.shmain/qemu/qemu_run.shInspect captured patch +11 / −11
diff --git a/main/qemu/qemu_gdb.sh b/main/qemu/qemu_gdb.sh
index 86ad5c1..695db77 100755
--- a/main/qemu/qemu_gdb.sh
+++ b/main/qemu/qemu_gdb.sh
@@ -1,10 +1,10 @@
-#!/bin/bash
+#!/usr/bin/env bash
+#
+if [ -z "${IDF_PATH}" ]; then
+ pushd /opt/esp/idf && . ./export.sh && popd
+fi
-set -eo pipefail
-
-pushd /opt/esp/idf && . ./export.sh && popd
-
-pkill -f qemu-system-xtensa | true
+pkill -f qemu-system-xtensa || true
qemu-system-xtensa -s -S -nographic \
-machine esp32 \
diff --git a/main/qemu/qemu_run.sh b/main/qemu/qemu_run.sh
index 972faa5..31840a7 100755
--- a/main/qemu/qemu_run.sh
+++ b/main/qemu/qemu_run.sh
@@ -1,10 +1,10 @@
-#!/bin/bash
+#!/usr/bin/env bash
#
-set -eo pipefail
+if [ -z "${IDF_PATH}" ]; then
+ pushd /opt/esp/idf && . ./export.sh && popd
+fi
-pushd /opt/esp/idf && . ./export.sh && popd
-
-pkill -f qemu-system-xtensa | true
+pkill -f qemu-system-xtensa || true
qemu-system-xtensa -nographic \
-machine esp32 \
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.