AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 63 Bitcoin

process: limit array sizes in sign_tx, register_multisig and sign_bip85_digests

Public commit record

What the developer wrote

Authored by Daniel Newton

50/100 · Thin
process: limit array sizes in sign_tx, register_multisig and sign_bip85_digests
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit adds size limits to several message-handling functions in the Blockstream Jade hardware wallet firmware. It caps how many asset records, transaction inputs/outputs, multisig signers, and BIP85 RSA digests a single RPC message can contain. The change appears to be a hardening patch: without these limits, an attacker or malformed host application could send an extremely large array and potentially exhaust device memory, cause long processing delays, or trigger memory corruption during signing and multisig registration. The patch also makes the array-length check happen earlier and more consistently across the code.

Recommended action

Treat this commit as a security hardening fix and include it in the next firmware release. Review whether any other RPC endpoints that accept arrays still lack similar bounds, and consider adding a global message-size budget or heap-canary checks to detect future memory-pressure issues.

Security signals we found

01

Adds explicit upper bounds on attacker-controllable array sizes

02

Rejects zero-input/zero-output transactions before further processing

03

Moves BIP85 digest count validation before memory allocation

04

Centralizes array-length extraction in rpc_get_array()

05

Adds regression tests for oversized arrays and empty transactions

Risk score

Why this scored 63/100

Our methodology →
Potential impact 18/30
Exploitability 14/25
Stealth signal 8/15
Affected reach 12/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.