ci: avoid downloading artifacts for non-flash testing
What the developer wrote
Authored by Jon Griffiths
ci: avoid downloading artifacts for non-flash testing
What changed, and why it matters
This commit only changes CI (Continuous Integration) pipeline configuration. It tells certain automated test jobs not to download build artifacts from previous stages because those tests do not need them. There is no change to the actual Jade firmware, wallet logic, cryptography, or any code that users run.
No security action needed. Treat as a normal CI maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff adds dependencies: [] to several GitLab CI test job definitions in gitlab/test.yml and gitlab/test_libjade.yml. In GitLab CI, dependencies controls which artifacts from prior jobs are downloaded. Setting it to an empty list prevents these test jobs from fetching artifacts they do not require. This is a CI optimization/cleanup with no effect on runtime code, attack surface, or security controls.
Changed components
GitLab CI pipeline definitions (gitlab/test.yml, gitlab/test_libjade.yml)Inspect captured patch +4 / −0
diff --git a/gitlab/test.yml b/gitlab/test.yml
index 81d9d1b..122d68b 100644
--- a/gitlab/test.yml
+++ b/gitlab/test.yml
@@ -5,6 +5,7 @@
test_bip85_rsa_key_gen:
tags: [ ga ]
stage: test
+ dependencies: []
script:
- pushd /opt/esp/idf && . ./export.sh && popd
- (cd tools/bip85_rsa_key_gen && ./test.sh)
@@ -13,6 +14,7 @@ test_bip85_rsa_key_gen:
test_format:
tags: [ ga ]
stage: test
+ dependencies: []
script:
- pushd /opt/esp/idf && . ./export.sh && popd
- ./format.sh
@@ -22,6 +24,7 @@ test_format:
test_configs:
tags: [ ga ]
stage: test
+ dependencies: []
script:
- ./tools/check_default_configs.sh
- git diff --exit-code
diff --git a/gitlab/test_libjade.yml b/gitlab/test_libjade.yml
index 0b4c163..2243bb7 100644
--- a/gitlab/test_libjade.yml
+++ b/gitlab/test_libjade.yml
@@ -1,5 +1,6 @@
.libjade_test_template:
tags: [ ga ]
+ dependencies: []
before_script:
- pushd /opt/esp/idf && . ./export.sh && popd
- ./tools/switch_to.sh jade --dev --noradio
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.