qr: show qrcodes with more contrast on jade v2 devices
What the developer wrote
Authored by Jon Griffiths
qr: show qrcodes with more contrast on jade v2 devices
What changed, and why it matters
This commit changes the background color used behind QR codes on newer Jade hardware (ESP32S3-based 'v2' devices) from a pale grey-green to pure white, because higher contrast makes the codes easier for phone cameras to scan. There is no security vulnerability here; it is a usability improvement for a specific device revision.
No security action needed. Treat as a normal quality/usability fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In main/gui.c the constant GUI_BLOCKSTREAM_QR_PALE is now defined conditionally: 0xFFFF (white) when CONFIG_IDF_TARGET_ESP32S3 is set, otherwise the original 0x494A (pale grey). The comment explicitly states the intent: ‘V2 QR codes scan better with a higher contrast background.’ This is a one-line color-value tweak guarded by a hardware target macro.
Changed components
main/gui.cQR code display rendering on Jade v2 (ESP32S3) devicesInspect captured patch +5 / −1
diff --git a/main/gui.c b/main/gui.c
index 98bec6a..e4547c2 100644
--- a/main/gui.c
+++ b/main/gui.c
@@ -37,8 +37,12 @@ ESP_EVENT_DEFINE_BASE(GUI_EVENT);
const color_t GUI_BLOCKSTREAM_JADE_GREEN = 0x4C04;
const color_t GUI_BLOCKSTREAM_BUTTONBORDER_GREY = 0x0421;
+#ifdef CONFIG_IDF_TARGET_ESP32S3
+// V2 QR codes scan better with a higher contrast background
+const color_t GUI_BLOCKSTREAM_QR_PALE = 0xFFFF;
+#else
const color_t GUI_BLOCKSTREAM_QR_PALE = 0x494A;
-
+#endif
const color_t GUI_BLOCKSTREAM_HIGHTLIGHT_DEFAULT = GUI_BLOCKSTREAM_JADE_GREEN;
const color_t GUI_BLOCKSTREAM_HIGHTLIGHT_ORANGE = 0xE0D3;
const color_t GUI_BLOCKSTREAM_HIGHTLIGHT_BLUE = 0xD318;
Why this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.