consistency: don't repeatedly re-set the activity when it doesn't change
What the developer wrote
Authored by Jon Griffiths
consistency: don't repeatedly re-set the activity when it doesn't change
What changed, and why it matters
This is a tiny code cleanup change in a hardware wallet's screen-handling logic. It moves one function call outside a loop so the screen is set once rather than repeatedly. There is no indication this fixes a security bug or affects funds, keys, or user safety.
No security action needed. Treat as routine code-quality/maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In main/process/mnemonic.c, the commit moves gui_set_current_activity(act) out of a while(true) loop in handle_bip85_mnemonic(). Previously the current GUI activity was re-set on every loop iteration; now it is set once before the loop. This is a consistency/cosmetic change with no observable security effect visible in the diff.
Changed components
main/process/mnemonic.chandle_bip85_mnemonic()BIP-85 derived mnemonic display flowInspect captured patch +1 / −2
diff --git a/main/process/mnemonic.c b/main/process/mnemonic.c
index 6664546..c8d2575 100644
--- a/main/process/mnemonic.c
+++ b/main/process/mnemonic.c
@@ -1505,11 +1505,10 @@ void handle_bip85_mnemonic()
}
gui_activity_t* act = make_bip85_mnemonic_words_activity();
+ gui_set_current_activity(act);
uint8_t nwords = 0;
while (true) {
- gui_set_current_activity(act);
-
const int32_t ev_id = gui_activity_wait_button(act, BTN_BIP85_12_WORDS);
if (ev_id == BTN_BIP85_12_WORDS) {
nwords = 12;
Why this scored 12/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.