tests: show mismatching values on reply failure
What the developer wrote
Authored by Jon Griffiths
tests: show mismatching values on reply failure
What changed, and why it matters
This commit only changes test code to print more helpful error messages when a test assertion fails. It does not modify the actual Jade wallet firmware or any production code. There is no security issue here.
No security action needed. Treat as routine test maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff updates three assert statements in test_jade.py to include descriptive f-strings showing the mismatching reply values on failure. This is a pure test-quality/debugging improvement with no functional or security changes to the Jade device code, RPC protocol, or test logic.
Changed components
test_jade.pyInspect captured patch +3 / −3
diff --git a/test_jade.py b/test_jade.py
index 17970c2..cc9b27b 100644
--- a/test_jade.py
+++ b/test_jade.py
@@ -2210,9 +2210,9 @@ def _set_wallet(jade, mnemonic=TEST_MNEMONIC, passphrase=None):
request = jade.build_request('id_mnem', 'debug_set_mnemonic',
{'mnemonic': mnemonic, 'passphrase': passphrase})
reply = jade.make_rpc_call(request)
- assert reply['id'] == request['id']
- assert 'error' not in reply
- assert reply['result'] is True
+ assert reply['id'] == request['id'], f"{reply['id']} != {request['id']}: {reply}"
+ assert 'error' not in reply, f'{reply}'
+ assert reply['result'] is True, f'{reply}'
# Get and return root xpub
request = jade.build_request('id_xpub', 'get_xpub',
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.