dashboard: fix qemu compile warnings
What the developer wrote
Authored by Jon Griffiths
dashboard: fix qemu compile warnings
What changed, and why it matters
This commit only wraps three optional hardware-specific functions in conditional compilation guards so the code compiles cleanly on QEMU emulator builds that lack a camera or battery. It is a build-warning cleanup with no security relevance.
No security action needed; treat as routine build hygiene.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff adds #ifdef CONFIG_HAS_CAMERA around handle_change_pin_qr() and handle_pinserver_scan(), and #ifdef CONFIG_HAS_BATTERY around handle_display_battery_volts(). These are purely compile-time guards to suppress unused-function warnings when the corresponding hardware features are absent (e.g., QEMU builds). No logic, interfaces, or security behavior is changed.
Changed components
main/process/dashboard.cInspect captured patch +6 / −0
diff --git a/main/process/dashboard.c b/main/process/dashboard.c
index c52df11..6464a72 100644
--- a/main/process/dashboard.c
+++ b/main/process/dashboard.c
@@ -1008,6 +1008,7 @@ static void handle_change_pin(void)
set_request_change_pin(change_pin);
}
+#ifdef CONFIG_HAS_CAMERA
static bool handle_change_pin_qr(void)
{
// Request/start a qr unlock
@@ -1031,6 +1032,7 @@ static bool handle_change_pin_qr(void)
keychain_clear();
return true;
}
+#endif // CONFIG_HAS_CAMERA
// Helper to delete a wallet registration record after user confirms
static bool offer_delete_registered_wallet(const char* name, const bool is_multisig)
@@ -1930,6 +1932,7 @@ static void handle_flip_orientation(void)
}
}
+#ifdef CONFIG_HAS_CAMERA
static void handle_pinserver_scan(void)
{
if (keychain_has_pin()) {
@@ -1967,6 +1970,7 @@ cleanup:
free(type);
free(data);
}
+#endif // CONFIG_HAS_CAMERA
static void handle_pinserver_reset(void)
{
@@ -2051,6 +2055,7 @@ static void handle_display_mac_address(void)
handle_info_detail_screen("MAC Address", mac);
}
+#ifdef CONFIG_HAS_BATTERY
static void handle_display_battery_volts(void)
{
char power_status[32] = "NO BAT";
@@ -2077,6 +2082,7 @@ static void handle_display_battery_volts(void)
handle_info_detail_screen("Battery Volts", power_status);
}
+#endif // CONFIG_HAS_BATTERY
static void update_network_menu_label(gui_view_node_t* network_type_item)
{
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.