gui: don't reuse the qrcode background color for unhighlighted buttons
What the developer wrote
Authored by Jon Griffiths
gui: don't reuse the qrcode background color for unhighlighted buttons
What changed, and why it matters
This commit changes the background color used for inactive buttons on a hardware wallet's home screen. Previously, the code reused the same pale color that backs QR codes; now it uses a dedicated default color. There is no security issue visible in the diff—it is purely a user-interface cleanup.
No security action needed. Treat as a normal UI/maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch introduces a new color constant GUI_BLOCKSTREAM_UNHIGHTLIGHTED_DEFAULT (0x494A) and uses it in make_home_screen_activity() instead of GUI_BLOCKSTREAM_QR_PALE for an unhighlighted home-screen panel item. It is a cosmetic decoupling of UI color definitions with no functional or security-bearing code change.
Changed components
main/gui.cmain/gui.hmain/ui/dashboard.cInspect captured patch +3 / −1
diff --git a/main/gui.c b/main/gui.c
index e4547c2..b934058 100644
--- a/main/gui.c
+++ b/main/gui.c
@@ -48,6 +48,7 @@ const color_t GUI_BLOCKSTREAM_HIGHTLIGHT_ORANGE = 0xE0D3;
const color_t GUI_BLOCKSTREAM_HIGHTLIGHT_BLUE = 0xD318;
const color_t GUI_BLOCKSTREAM_HIGHTLIGHT_DARKGREY = 0xA210;
const color_t GUI_BLOCKSTREAM_HIGHTLIGHT_LIGHTGREY = 0xB294;
+const color_t GUI_BLOCKSTREAM_UNHIGHTLIGHTED_DEFAULT = 0x494A;
typedef struct _activity_holder_t activity_holder_t;
struct _activity_holder_t {
diff --git a/main/gui.h b/main/gui.h
index d2dd90f..3e39ee3 100644
--- a/main/gui.h
+++ b/main/gui.h
@@ -19,6 +19,7 @@ extern const color_t GUI_BLOCKSTREAM_HIGHTLIGHT_ORANGE;
extern const color_t GUI_BLOCKSTREAM_HIGHTLIGHT_BLUE;
extern const color_t GUI_BLOCKSTREAM_HIGHTLIGHT_DARKGREY;
extern const color_t GUI_BLOCKSTREAM_HIGHTLIGHT_LIGHTGREY;
+extern const color_t GUI_BLOCKSTREAM_UNHIGHTLIGHTED_DEFAULT;
// -------------- Configuration -----------------
diff --git a/main/ui/dashboard.c b/main/ui/dashboard.c
index 3521dcf..9d19aed 100644
--- a/main/ui/dashboard.c
+++ b/main/ui/dashboard.c
@@ -88,7 +88,7 @@ gui_activity_t* make_home_screen_activity(const char* device_name, const char* f
gui_set_parent(node, hsplit);
// Next item
- node = make_home_screen_panel_item(GUI_BLOCKSTREAM_QR_PALE, next_entry);
+ node = make_home_screen_panel_item(GUI_BLOCKSTREAM_UNHIGHTLIGHTED_DEFAULT, next_entry);
gui_set_borders(node, TFT_BLACK, 6, GUI_BORDER_LEFT);
gui_set_parent(node, hsplit);
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.