What the developer wrote
Authored by Jon Griffiths
ci: disable 1.0 flashing jobs
These devices do not always cleanly reboot and thus the CI is
not suitable for automatation.
What changed, and why it matters
This commit only changes internal CI (continuous integration) configuration. It comments out automated test jobs that flash firmware onto older Jade v1.0 hardware because those devices do not reliably reboot during testing. There is no change to the product firmware, no user-facing change, and no security fix or vulnerability patch.
No security action required. Treat as routine CI maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies gitlab/flash.yml, disabling three GitLab CI jobs (flash_jade_ci, flash_jade_noradio_ci, flash_jade_ota_delta_ci) that program physical Jade v1.0 devices in the test lab. A preceding comment already marked v1.0 flashing as flaky (‘devices sometimes don’t come back from reboot’). The change is purely operational/test-infrastructure hygiene.
Changed components
gitlab/flash.yml CI pipeline configurationInspect captured patch +26 / −26
diff --git a/gitlab/flash.yml b/gitlab/flash.yml
index 6b66e3a..5210790 100644
--- a/gitlab/flash.yml
+++ b/gitlab/flash.yml
@@ -53,32 +53,32 @@ flash_qemu_psram_unamalgamated:
# FIXME: Fix v1.0 flashing (devices sometimes don't come back from reboot)
allow_failure: true
-flash_jade_ci:
- extends: .flash_jade_template
- needs: [ test_libjade, build_test_jade_ci ]
-
-flash_jade_noradio_ci:
- extends: .flash_jade_template
- needs:
- - job: build_test_jade_noradio_ci
- artifacts: true
- - job: flash_jade_ci
- artifacts: false
-
-flash_jade_ota_delta_ci:
- extends: .flash_jade_template
- needs:
- - job: build_test_jade_ci
- artifacts: true
- - job: build_test_jade_noradio_ci
- artifacts: true
- - job: flash_jade_noradio_ci
- artifacts: false
- script:
- - mv build_test_jade_ci build
- - mv build_test_jade_noradio_ci build_noradio
- - git submodule update --init --depth 1 pinserver
- - docker-compose run --remove-orphans --rm dev bash -c "JADESERIALPORT=$JADESERIALPORT ./ota_delta_ci.sh esp32 --skipble"
+#flash_jade_ci:
+# extends: .flash_jade_template
+# needs: [ test_libjade, build_test_jade_ci ]
+
+#flash_jade_noradio_ci:
+# extends: .flash_jade_template
+# needs:
+# - job: build_test_jade_noradio_ci
+# artifacts: true
+# - job: flash_jade_ci
+# artifacts: false
+
+#flash_jade_ota_delta_ci:
+# extends: .flash_jade_template
+# needs:
+# - job: build_test_jade_ci
+# artifacts: true
+# - job: build_test_jade_noradio_ci
+# artifacts: true
+# - job: flash_jade_noradio_ci
+# artifacts: false
+# script:
+# - mv build_test_jade_ci build
+# - mv build_test_jade_noradio_ci build_noradio
+# - git submodule update --init --depth 1 pinserver
+# - docker-compose run --remove-orphans --rm dev bash -c "JADESERIALPORT=$JADESERIALPORT ./ota_delta_ci.sh esp32 --skipble"
# Jade v1.1
.flash_jade_v1_1_template:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.