build: update QEMU Docker container
What the developer wrote
Authored by Mike Tolkachev
build: update QEMU Docker container
Update the QEMU Docker container to keep it buildable with a recent
version of Docker. Also fix issue with non-activated ESP environment
before running make_flash_img.sh.
What changed, and why it matters
This commit is a routine build-script maintenance change for the QEMU Docker container used to emulate the Jade hardware wallet. It merges two build commands into one so the ESP-IDF environment stays activated, and updates the container command syntax for newer Docker versions. There is no indication this affects the security of the actual Jade firmware or real devices.
No security action required. Treat as normal build maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The Dockerfile.qemu change combines the firmware build and flash-image creation steps into a single RUN instruction so that the ESP-IDF export.sh environment remains sourced when make_flash_img.sh runs. It also changes the CMD from a JSON array with an unexpanded variable to a shell form that expands ${QEMU_GDB}. This is a build-environment fix, not a firmware or runtime security patch.
Changed components
Dockerfile.qemu (QEMU build container)Inspect captured patch +2 / −3
diff --git a/Dockerfile.qemu b/Dockerfile.qemu
index 5ad9499..d00839d 100644
--- a/Dockerfile.qemu
+++ b/Dockerfile.qemu
@@ -7,6 +7,5 @@ WORKDIR /jade
COPY . .
RUN ./tools/switch_to.sh qemu ${QEMU_CONFIG_ARGS}
-RUN cd /opt/esp/idf && . ./export.sh && cd /jade && idf.py all && ./tools/fwprep.py build/jade.bin build
-RUN ./main/qemu/make_flash_img.sh
-CMD [ "/jade/main/qemu/qemu_run.sh", "$QEMU_GDB" ]
+RUN cd /opt/esp/idf && . ./export.sh && cd /jade && idf.py all && ./tools/fwprep.py build/jade.bin build && ./main/qemu/make_flash_img.sh
+CMD ["sh", "-c", "exec /jade/main/qemu/qemu_run.sh ${QEMU_GDB}"]
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.