Merge bitcoin/bitcoin#36685: wallet: export replaces_txid and replaced_by_txid
What changed, and why it matters
This commit simply exposes two existing transaction-replacement identifiers (replaces_txid and replaced_by_txid) through an internal wallet interface so that a future QML-based user interface can read them. It is a straightforward data plumbing change with no security implications.
No security action needed; review as normal code-quality/functional change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch adds two std::optional
Changed components
src/interfaces/wallet.hsrc/wallet/interfaces.cppInspect captured patch +4 / −0
### src/interfaces/wallet.h
@@ -406,6 +406,8 @@ struct WalletTx
std::optional<std::string> message; // Deprecated
std::optional<std::string> comment;
std::optional<std::string> comment_to;
+ std::optional<Txid> replaces_txid;
+ std::optional<Txid> replaced_by_txid;
bool is_coinbase;
bool operator<(const WalletTx& a) const { return tx->GetHash() < a.tx->GetHash(); }
### src/wallet/interfaces.cpp
@@ -85,6 +85,8 @@ WalletTx MakeWalletTx(CWallet& wallet, const CWalletTx& wtx)
result.message = wtx.m_message;
result.comment = wtx.m_comment;
result.comment_to = wtx.m_comment_to;
+ result.replaces_txid = wtx.m_replaces_txid;
+ result.replaced_by_txid = wtx.m_replaced_by_txid;
result.is_coinbase = wtx.IsCoinBase();
return result;
}Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.