AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge bitcoin/bitcoin#36685: wallet: export replaces_txid and replaced_by_txid

Public commit record

What the developer wrote

Authored by merge-script

81/100 · Strong
Merge bitcoin/bitcoin#36685: wallet: export replaces_txid and replaced_by_txid

bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0 wallet: export replaces_txid and replaced_by_txid (Vasil Dimov)

Pull request description:

Export the fields `replaces_txid` and `replaced_by_txid` from `wallet::CWalletTx` to `interfaces::WalletTx`.

In May 2026 https://github.com/bitcoin-core/gui-qml/commit/f4ff2b8db93cea7ce16c1b914bd4a89393a5810c hooked a usage of `interfaces::WalletTx::value_map["replaces_txid"]` and `interfaces::WalletTx::value_map["replaced_by_txid"]` into the QML GUI.

Then, in June 2026 https://github.com/bitcoin/bitcoin/commit/a2b0bfcd854548820057143f9b5b2213736c5497 removed the map entirely from the main repository, but the `replaces_txid` and `replaced_by_txid` fields were not exposed in `interfaces::WalletTx`. Thus the QML GUI has no access to them.

Export the fields to solve this.

The QT5 GUI never used those.

ACKs for top commit:
pseudoramdom:
ACK bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0
johnny9:
ACK bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0
sedited:
ACK bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0

Tree-SHA512: 2dcfd67ef2cca6bef778911d3e8039a91d3eca5d26d4ca7a83c31ebba71aced8b3b7add825baa001f2466ba6e4e7180764fe5d0a8ff99ebe98eb7c80635d385e
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit simply exposes two existing transaction-replacement identifiers (replaces_txid and replaced_by_txid) through an internal wallet interface so that a future QML-based user interface can read them. It is a straightforward data plumbing change with no security implications.

Recommended action

No security action needed; review as normal code-quality/functional change.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.