ci: Clarify why valgrind task has gui disabled
What the developer wrote
Authored by MarcoFalke
ci: Clarify why valgrind task has gui disabled
A build with system libs (or with a normal depends build) will fail
with:
```sh
$ valgrind --exit-on-first-error=yes --error-exitcode=1 --quiet ./bld-cmake/bin/test_bitcoin-qt
Detected locale "C" with character encoding "ANSI_X3.4-1968", which is not UTF-8.
Qt depends on a UTF-8 locale, and has switched to "C.UTF-8" instead.
If this causes problems, reconfigure your locale. See the locale(1) manual
for more information.
********* Start testing of AppTests *********
Config: Using QtTest library 6.10.2, Qt 6.10.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 15.2.0), ubuntu 26.04
PASS : AppTests::initTestCase()
QINFO : AppTests::appTests() Backing up GUI settings to "/tmp/test_common bitcoin/60d474ffae390f81657d/regtest/guisettings.ini.bak"
==18007== Conditional jump or move depends on uninitialised value(s)
==18007== at 0x12655E26: ???
==18007== by 0xCB28E7F: ???
==18007==
==18007==
==18007== Exit program on first error (--exit-on-first-error=yes)
```
A DEBUG=1 depends build would work, but that seems tedious for
questionable benefit.
What changed, and why it matters
This is a documentation-only change to a continuous integration script. A developer replaced a vague 'TODO enable GUI' comment with a clearer explanation that the GUI is disabled in the valgrind CI task because it only passes with a special debug build. No code behavior changed, and there is no security fix or vulnerability here.
No security action needed. This is a non-functional CI comment clarification.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies ci/test/00_setup_env_native_valgrind.sh, changing a comment from ‘# TODO enable GUI’ to ‘# GUI disabled, because it only passes with a DEBUG=1 depends build’. The actual BITCOIN_CONFIG setting (-DBUILD_GUI=OFF) is unchanged. The commit message describes a valgrind uninitialized-value issue observed in test_bitcoin-qt, but this is background context for the comment clarification, not a code change that addresses it.
Changed components
ci/test/00_setup_env_native_valgrind.shInspect captured patch +1 / −1
diff --git a/ci/test/00_setup_env_native_valgrind.sh b/ci/test/00_setup_env_native_valgrind.sh
index 30c84bf4..89118324 100755
--- a/ci/test/00_setup_env_native_valgrind.sh
+++ b/ci/test/00_setup_env_native_valgrind.sh
@@ -15,7 +15,7 @@ export NO_DEPENDS=1
# bind tests excluded for now, see https://github.com/bitcoin/bitcoin/issues/17765#issuecomment-602068547
export TEST_RUNNER_EXTRA="--exclude rpc_bind --exclude feature_bind_extra"
export GOAL="install"
-# TODO enable GUI
+# GUI disabled, because it only passes with a DEBUG=1 depends build
export BITCOIN_CONFIG="\
--preset=dev-mode \
-DBUILD_GUI=OFF \
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.