test: Use proper noban permission for faster tx relay
What changed, and why it matters
This is a minor test-only change in Bitcoin Core's functional test suite. It replaces a manual whitelist flag with a built-in test framework option that achieves the same goal for both incoming and outgoing peer connections. There is no change to production code, no security fix, and no vulnerability.
No action required. This is a benign test-only refactor.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies test/functional/rpc_psbt.py. Previously the test appended -whitelist=noban@127.0.0.1 to each node’s extra_args, which only affected inbound connections. The change removes that loop and instead sets self.noban_tx_relay = True, a test framework property that ensures the noban permission is applied correctly for faster transaction relay across all connections. This is purely a test reliability/performance improvement.
Changed components
test/functional/rpc_psbt.pyInspect captured patch +1 / −2
### test/functional/rpc_psbt.py
@@ -86,8 +86,7 @@ def set_test_params(self):
["-maxfeerate=1"]
]
# whitelist peers to speed up tx relay / mempool sync
- for args in self.extra_args:
- args.append("-whitelist=noban@127.0.0.1")
+ self.noban_tx_relay = True
def skip_test_if_missing_module(self):
self.skip_if_no_wallet()Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.