ci: Remove redundant RUN_UNIT_TESTS_SEQUENTIAL
What the developer wrote
Authored by MarcoFalke
ci: Remove redundant RUN_UNIT_TESTS_SEQUENTIAL
What changed, and why it matters
This commit is a routine cleanup of Bitcoin Core's continuous integration (CI) scripts. It removes an unused environment variable called RUN_UNIT_TESTS_SEQUENTIAL and merges its behavior into the standard unit test path. There is no change to the Bitcoin software that users run, no security fix, and no vulnerability.
No security action needed. Review as normal CI maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch removes the RUN_UNIT_TESTS_SEQUENTIAL flag from CI configuration and the test runner script. Previously, some CI jobs set this flag to run unit tests sequentially instead of in parallel. The commit makes sequential execution the default behavior for the relevant Windows CI job by adding a comment and removes the now-redundant variable and code branch. It is a refactoring of CI orchestration, not a code or protocol change.
Changed components
.github/workflows/ci.ymlci/test/00_setup_env_native_previous_releases.shci/test/03_test_script.shInspect captured patch +2 / −8
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 6876b832..1f729a62 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -379,7 +379,7 @@ jobs:
- name: Run unit tests
# Can't use ctest here like other jobs as we don't have a CMake build tree.
run: |
- ./bin/test_bitcoin.exe -l test_suite
+ ./bin/test_bitcoin.exe -l test_suite # Intentionally run sequentially here, to catch test case failures caused by dirty global state from prior test cases.
./src/secp256k1/bin/exhaustive_tests.exe
./src/secp256k1/bin/noverify_tests.exe
./src/secp256k1/bin/tests.exe
diff --git a/ci/test/00_setup_env_native_previous_releases.sh b/ci/test/00_setup_env_native_previous_releases.sh
index 7a7544b3..d9f8d3bf 100755
--- a/ci/test/00_setup_env_native_previous_releases.sh
+++ b/ci/test/00_setup_env_native_previous_releases.sh
@@ -12,8 +12,6 @@ export CI_IMAGE_NAME_TAG="mirror.gcr.io/ubuntu:22.04"
export PACKAGES="gcc-11 g++-11 python3-zmq"
export DEP_OPTS="CC=gcc-11 CXX=g++-11"
export TEST_RUNNER_EXTRA="--previous-releases --coverage --extended --exclude feature_dbcrash" # Run extended tests so that coverage does not fail, but exclude the very slow dbcrash
-export RUN_UNIT_TESTS_SEQUENTIAL="true"
-export RUN_UNIT_TESTS="false"
export GOAL="install"
export CI_LIMIT_STACK_SIZE=1
export DOWNLOAD_PREVIOUS_RELEASES="true"
diff --git a/ci/test/03_test_script.sh b/ci/test/03_test_script.sh
index a5248b8d..e0935750 100755
--- a/ci/test/03_test_script.sh
+++ b/ci/test/03_test_script.sh
@@ -74,7 +74,7 @@ if [ "$RUN_FUZZ_TESTS" = "true" ]; then
echo "Using qa-assets repo from commit ..."
git log -1
)
-elif [ "$RUN_UNIT_TESTS" = "true" ] || [ "$RUN_UNIT_TESTS_SEQUENTIAL" = "true" ]; then
+elif [ "$RUN_UNIT_TESTS" = "true" ]; then
export DIR_UNIT_TEST_DATA=${DIR_QA_ASSETS}/unit_test_data/
if [ ! -d "$DIR_UNIT_TEST_DATA" ]; then
mkdir -p "$DIR_UNIT_TEST_DATA"
@@ -176,10 +176,6 @@ if [ "$RUN_UNIT_TESTS" = "true" ]; then
--timeout $(( TEST_RUNNER_TIMEOUT_FACTOR * 60 ))
fi
-if [ "$RUN_UNIT_TESTS_SEQUENTIAL" = "true" ]; then
- DIR_UNIT_TEST_DATA="${DIR_UNIT_TEST_DATA}" LD_LIBRARY_PATH="${DEPENDS_DIR}/${HOST}/lib" "${BASE_BUILD_DIR}"/bin/test_bitcoin --catch_system_errors=no -l test_suite
-fi
-
if [ "$RUN_FUNCTIONAL_TESTS" = "true" ]; then
# parses TEST_RUNNER_EXTRA as an array which allows for multiple arguments such as TEST_RUNNER_EXTRA='--exclude "rpc_bind.py --ipv6"'
eval "TEST_RUNNER_EXTRA=($TEST_RUNNER_EXTRA)"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.