ci: [refactor] Base nowallet task on --preset=dev-mode
What the developer wrote
Authored by MarcoFalke
ci: [refactor] Base nowallet task on --preset=dev-mode
This makes it clearer what pieces are disabled over the full dev-mode.
The wallet remains explicitly disabled.
What changed, and why it matters
This is a routine internal cleanup of Bitcoin Core's continuous integration (CI) testing setup. It renames a test job from 'No wallet, libbitcoinkernel' to 'No wallet' and switches its build configuration to use a standard developer preset while still explicitly turning off the wallet. There is no change to the actual Bitcoin node software that users run, and nothing in the commit suggests a security issue.
No security action needed. This is a normal maintenance/refactoring commit affecting CI only.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit refactors a CI task. It deletes ci/test/00_setup_env_native_nowallet_libbitcoinkernel.sh and creates ci/test/00_setup_env_native_nowallet.sh. The new script uses –preset=dev-mode plus -DREDUCE_EXPORTS=ON and -DENABLE_WALLET=OFF, whereas the old script used individual CMake flags including BUILD_UTIL_CHAINSTATE, BUILD_KERNEL_LIB, BUILD_KERNEL_TEST, and BUILD_SHARED_LIBS. The GitHub Actions workflow is updated to point to the new script and rename the job. This is purely a build/test configuration change.
Changed components
Bitcoin Core CI configurationGitHub Actions workflow (.github/workflows/ci.yml)CI environment script (ci/test/00_setup_env_native_nowallet.sh)Inspect captured patch +22 / −18
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 52e77997..e9870e93 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -487,11 +487,11 @@ jobs:
timeout-minutes: 120
file-env: './ci/test/00_setup_env_mac_cross_intel.sh'
- - name: 'No wallet, libbitcoinkernel'
+ - name: 'No wallet'
cirrus-runner: 'ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04-sm'
fallback-runner: 'ubuntu-24.04'
timeout-minutes: 120
- file-env: './ci/test/00_setup_env_native_nowallet_libbitcoinkernel.sh'
+ file-env: './ci/test/00_setup_env_native_nowallet.sh'
- name: 'i686, no IPC'
cirrus-runner: 'ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04-md'
diff --git a/ci/test/00_setup_env_native_nowallet.sh b/ci/test/00_setup_env_native_nowallet.sh
new file mode 100755
index 00000000..28446a70
--- /dev/null
+++ b/ci/test/00_setup_env_native_nowallet.sh
@@ -0,0 +1,20 @@
+#!/usr/bin/env bash
+#
+# Copyright (c) 2019-present The Bitcoin Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+export LC_ALL=C.UTF-8
+
+export CONTAINER_NAME=ci_native_nowallet
+export CI_IMAGE_NAME_TAG="mirror.gcr.io/ubuntu:24.04"
+# Use minimum supported python3.10 (or best-effort 3.12) and clang-17, see doc/dependencies.md
+export PACKAGES="python3-zmq python3-pip clang-17 llvm-17 libc++abi-17-dev libc++-17-dev"
+export PIP_PACKAGES="--break-system-packages pycapnp"
+export DEP_OPTS="NO_WALLET=1 CC=clang-17 CXX='clang++-17 -stdlib=libc++'"
+export GOAL="install"
+export BITCOIN_CONFIG="\
+ --preset=dev-mode \
+ -DREDUCE_EXPORTS=ON \
+ -DENABLE_WALLET=OFF \
+"
diff --git a/ci/test/00_setup_env_native_nowallet_libbitcoinkernel.sh b/ci/test/00_setup_env_native_nowallet_libbitcoinkernel.sh
deleted file mode 100755
index 10417779..00000000
--- a/ci/test/00_setup_env_native_nowallet_libbitcoinkernel.sh
+++ /dev/null
@@ -1,16 +0,0 @@
-#!/usr/bin/env bash
-#
-# Copyright (c) 2019-present The Bitcoin Core developers
-# Distributed under the MIT software license, see the accompanying
-# file COPYING or http://www.opensource.org/licenses/mit-license.php.
-
-export LC_ALL=C.UTF-8
-
-export CONTAINER_NAME=ci_native_nowallet_libbitcoinkernel
-export CI_IMAGE_NAME_TAG="mirror.gcr.io/ubuntu:24.04"
-# Use minimum supported python3.10 (or best-effort 3.12) and clang-17, see doc/dependencies.md
-export PACKAGES="python3-zmq python3-pip clang-17 llvm-17 libc++abi-17-dev libc++-17-dev"
-export PIP_PACKAGES="--break-system-packages pycapnp"
-export DEP_OPTS="NO_WALLET=1 CC=clang-17 CXX='clang++-17 -stdlib=libc++'"
-export GOAL="install"
-export BITCOIN_CONFIG="-DREDUCE_EXPORTS=ON -DBUILD_UTIL_CHAINSTATE=ON -DBUILD_KERNEL_LIB=ON -DBUILD_KERNEL_TEST=ON -DBUILD_SHARED_LIBS=ON"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.