ci: Set PREVIOUS_RELEASES_DIR env var in ci-windows-cross.py
What the developer wrote
Authored by MarcoFalke
ci: Set PREVIOUS_RELEASES_DIR env var in ci-windows-cross.py
This uses the workspace instead of the runner.temp, so that it is easier
to reproduce the CI locally.
What changed, and why it matters
This is a small change to Bitcoin Core's internal continuous integration (CI) scripts. It moves the location where downloaded previous Bitcoin releases are stored from a temporary CI folder to the current workspace directory, making it easier for developers to reproduce CI test runs on their own machines. There is no user-facing change, no wallet or network code change, and no security issue visible in the diff.
No security action required. Treat as a normal CI maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies .github/ci-windows-cross.py to set the PREVIOUS_RELEASES_DIR environment variable to Path.cwd() / 'previous_releases' if not already set, and removes the corresponding echo ... >> $GITHUB_ENV step from .github/workflows/ci.yml. This is a CI-only refactor that changes where prior release binaries are cached during Windows cross-compilation test jobs. It does not alter consensus, P2P, wallet, RPC, or cryptographic code.
Changed components
.github/ci-windows-cross.py.github/workflows/ci.ymlInspect captured patch +5 / −4
diff --git a/.github/ci-windows-cross.py b/.github/ci-windows-cross.py
index 0085ede9..9b59f2a2 100755
--- a/.github/ci-windows-cross.py
+++ b/.github/ci-windows-cross.py
@@ -127,6 +127,11 @@ def main():
parser.add_argument("step", choices=steps, help="CI step to perform.")
args = parser.parse_args()
+ os.environ.setdefault(
+ "PREVIOUS_RELEASES_DIR",
+ str(Path.cwd() / "previous_releases"),
+ )
+
if args.step == "print_version":
print_version()
elif args.step == "check_manifests":
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index d310f3a5..c821999e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -425,10 +425,6 @@ jobs:
./src/univalue/object.exe
./src/univalue/unitester.exe
- - name: Set previous release directory
- run: |
- echo "PREVIOUS_RELEASES_DIR=${{ runner.temp }}/previous_releases" >> "$GITHUB_ENV"
-
- name: Prepare Windows test environment
run: |
py -3 .github/ci-windows-cross.py prepare_tests
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.