What the developer wrote
Authored by MarcoFalke
ci: Require rsync to pass
In theory one could run the CI without the rsync package installed, and
with DANGER_RUN_CI_ON_HOST=1. However, this seems to be an edge case.
Simply requiring rsync to be installed is less code and avoids brittle
edge cases around rsync failures.
What changed, and why it matters
This is a small change to Bitcoin Core's internal continuous integration (CI) shell script. It removes a fallback message that previously printed if the rsync command failed, so rsync is now treated as a hard requirement. The change does not affect the Bitcoin network, wallets, consensus rules, or production nodes. It only matters if someone runs the CI system directly on their host machine without rsync installed, which the commit message itself calls an edge case.
No security action required. Treat as a normal CI maintenance commit. Reviewers may verify that CI runners have rsync installed, which is already the expected environment.
Security signals we found
Change is confined to CI infrastructure shell script
No modification of consensus, networking, wallet, or cryptographic code
No input validation, privilege boundary, or memory-safety change
Commit message frames change as code simplification, not as a vulnerability fix
Evidence from the diff
In ci/test/02_run_container.sh, the trailing || echo "Nothing to copy..." was removed from the rsync invocation that copies the read-only source tree into the writable CI working directory. Previously, if rsync was missing or failed, the script would emit a message and continue. Now the script will fail at that point. This is a CI hardening/cleanup change, not a security patch for shipped code.
Changed components
ci/test/02_run_container.shInspect captured patch +1 / −1
diff --git a/ci/test/02_run_container.sh b/ci/test/02_run_container.sh
index eac8a0e5..9771065e 100755
--- a/ci/test/02_run_container.sh
+++ b/ci/test/02_run_container.sh
@@ -18,6 +18,6 @@ CI_EXEC () {
export -f CI_EXEC
# Normalize all folders to BASE_ROOT_DIR
-CI_EXEC rsync --recursive --perms --stats --human-readable "${BASE_READ_ONLY_DIR}/" "${BASE_ROOT_DIR}" || echo "Nothing to copy from ${BASE_READ_ONLY_DIR}/"
+CI_EXEC rsync --recursive --perms --stats --human-readable "${BASE_READ_ONLY_DIR}/" "${BASE_ROOT_DIR}"
CI_EXEC "${BASE_ROOT_DIR}/ci/test/01_base_install.sh"
CI_EXEC "${BASE_ROOT_DIR}/ci/test/03_test_script.sh"
Why this scored 21/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.