What the developer wrote
Authored by MarcoFalke
ci: Remove unused MAYBE_CPUSET
The option is currently unused. If it is used again in the future, it
could trivially be added back.
Also, the logic is just a single undocumented python command one-liner.
So remove it for now.
What changed, and why it matters
This commit removes an unused CI (Continuous Integration) option called MAYBE_CPUSET from a shell script that builds test containers. It is a cleanup change with no security relevance.
No action required; this is a benign CI cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes 8 lines from ci/test/02_run_container.sh, removing logic that conditionally added a Docker –cpuset-cpus build argument based on the HAVE_CGROUP_CPUSET environment variable. The commit message states the option is currently unused and can be re-added later if needed. No functional behavior is changed in production code, and no security boundary is affected.
Changed components
ci/test/02_run_container.shInspect captured patch +0 / −8
diff --git a/ci/test/02_run_container.sh b/ci/test/02_run_container.sh
index e91f8753..b26cc1b8 100755
--- a/ci/test/02_run_container.sh
+++ b/ci/test/02_run_container.sh
@@ -10,13 +10,6 @@ export CI_IMAGE_LABEL="bitcoin-ci-test"
set -o errexit -o pipefail -o xtrace
if [ -z "$DANGER_RUN_CI_ON_HOST" ]; then
- # Env vars during the build can not be changed. For example, a modified
- # $MAKEJOBS is ignored in the build process. Use --cpuset-cpus as an
- # approximation to respect $MAKEJOBS somewhat, if cpuset is available.
- MAYBE_CPUSET=""
- if [ "$HAVE_CGROUP_CPUSET" ]; then
- MAYBE_CPUSET="--cpuset-cpus=$( python3 -c "import random;P=$( nproc );M=min(P,int('$MAKEJOBS'.lstrip('-j')));print(','.join(map(str,sorted(random.sample(range(P),M)))))" )"
- fi
echo "Creating $CI_IMAGE_NAME_TAG container to run in"
# Use buildx unconditionally
@@ -27,7 +20,6 @@ if [ -z "$DANGER_RUN_CI_ON_HOST" ]; then
--build-arg "CI_IMAGE_NAME_TAG=${CI_IMAGE_NAME_TAG}" \
--build-arg "FILE_ENV=${FILE_ENV}" \
--build-arg "BASE_ROOT_DIR=${BASE_ROOT_DIR}" \
- $MAYBE_CPUSET \
--platform="${CI_IMAGE_PLATFORM}" \
--label="${CI_IMAGE_LABEL}" \
--tag="${CONTAINER_NAME}" \
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.