What the developer wrote
Authored by MarcoFalke
ci: [refactor] Drop last use of pwsh
Seems easier to just use Bash and Python consistently.
What changed, and why it matters
This commit is a minor cleanup in the project's automated testing configuration. It replaces a PowerShell script snippet with an equivalent Bash snippet that does the same thing: record the versions of build tools like CMake and MSBuild. There is no security issue here.
No action needed. This is a routine CI refactor with no security relevance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change refactors a single GitHub Actions CI step in .github/workflows/ci.yml from shell: pwsh to a Bash run block. Functionality is preserved: Tee-Object is replaced with tee, Write-Output with echo, $env:VCToolsVersion with ${VCToolsVersion-}, and msbuild is invoked as msbuild.exe. The set -o errexit -o pipefail -o xtrace -o nounset line actually strengthens error handling compared to the previous PowerShell block. No code affecting Bitcoin Core’s runtime, consensus, wallet, or networking is modified.
Changed components
.github/workflows/ci.ymlInspect captured patch +6 / −6
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 2059adc4..d79486fe 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -232,14 +232,14 @@ jobs:
run: py -3 .github/ci-windows.py "standard" github_import_vs_env
- name: Get tool information
- shell: pwsh
run: |
- cmake -version | Tee-Object -FilePath "cmake_version"
- Write-Output "---"
- msbuild -version | Tee-Object -FilePath "msbuild_version"
- $env:VCToolsVersion | Tee-Object -FilePath "toolset_version"
+ set -o errexit -o pipefail -o xtrace -o nounset
+
+ cmake -version | tee cmake_version
+ echo '---'
+ msbuild.exe -version | tee msbuild_version
+ echo "${VCToolsVersion-}" | tee toolset_version
py -3 --version
- Write-Host "PowerShell version $($PSVersionTable.PSVersion.ToString())"
bash --version
- name: Using vcpkg with MSBuild
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.