Revert "valgrind: add suppression for bug 472219"
What the developer wrote
Authored by MarcoFalke
Revert "valgrind: add suppression for bug 472219"
This reverts commit 50f7214e0915a88dd81c1ac1d292e049a398cda2.
What changed, and why it matters
This commit removes a Valgrind suppression rule. Valgrind is a debugging tool used to detect memory errors; a suppression rule simply tells Valgrind to ignore a known, harmless false-positive warning. Removing it does not change Bitcoin Core's actual code, behavior, or security. It only affects internal testing diagnostics, and only on a specific platform (musl libc on 64-bit ARM) when running Valgrind. The suppression was originally added because of a bug in Valgrind itself, which the commit message says is fixed in Valgrind 3.22.
No security action required. Treat as a normal maintenance/cleanup change. If the project still tests against Valgrind versions older than 3.22 on musl aarch64, CI may see restored false-positive warnings; consider pinning or documenting the minimum Valgrind version instead.
Security signals we found
No executable code changed
Only a Valgrind suppression file was modified
Change removes, not adds, a diagnostic exception
Commit explicitly references an upstream Valgrind bug fix
Evidence from the diff
The change reverts commit 50f7214e0915a88dd81c1ac1d292e049a398cda2, deleting a Valgrind suppression entry for KDE bug 472219 in contrib/valgrind.supp. The suppression masked a Memcheck false positive on the ppoll(ufds.events) parameter in /lib/ld-musl-aarch64.so.1. The commit message states the upstream Valgrind bug is fixed in version 3.22. No runtime code is modified; only CI/debug tooling configuration changes.
Changed components
contrib/valgrind.suppInspect captured patch +0 / −6
diff --git a/contrib/valgrind.supp b/contrib/valgrind.supp
index 7960f9c8..ef53f380 100644
--- a/contrib/valgrind.supp
+++ b/contrib/valgrind.supp
@@ -56,9 +56,3 @@
...
fun:_ZN5BCLog6Logger12StartLoggingEv
}
-{
- Suppress https://bugs.kde.org/show_bug.cgi?id=472219 - fixed in Valgrind 3.22.
- Memcheck:Param
- ppoll(ufds.events)
- obj:/lib/ld-musl-aarch64.so.1
-}
Why this scored 12/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.